Bug 67794 – WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string

• Component: WebKit2
• Status: RESOLVED FIXED

[Brian Weinstein]

We shouldn't call WebHistoryClient::didPerformClientRedirect or WebHistoryClient::didPerformServerRedirect when the source or destination URL string is empty or null. When we are creating a CFURLRef from a WKURL in WKURLCF.cpp, we assert that the string inside the WKURLRef is non-null.

Calling WebHistoryClient::didPerform*Redirect will turn the URL strings into URLs, and we don't want that in the case where they are null or empty.

<rdar://problem/9892024>

[Brian Weinstein]

Created attachment 106797 [details]
[PATCH] Fix + Test

[Adam Roben (:aroben)]

Comment on attachment 106797 [details]
[PATCH] Fix + Test

View in context: https://bugs.webkit.org/attachment.cgi?id=106797&action=review

> Source/WebKit2/ChangeLog:4
> +        WebKit2: Don't call WebHistoryClient didPerform*Redirect when source or destination is empty
> +        https://bugs.webkit.org/show_bug.cgi?id=67794

It would be better if the bug title described a user-visible symptom.

> Source/WebKit2/ChangeLog:8
> +        Don't call didPerformClientRedirect or didPerformServerRedirect when source or destination URL string
> +        is empty or null.

If the bug title described an actual problem, your ChangeLog might become more informative.

[Brian Weinstein]

(In reply to comment #2)
> (From update of attachment 106797 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106797&action=review
> 
> > Source/WebKit2/ChangeLog:4
> > +        WebKit2: Don't call WebHistoryClient didPerform*Redirect when source or destination is empty
> > +        https://bugs.webkit.org/show_bug.cgi?id=67794
> 
> It would be better if the bug title described a user-visible symptom.

Changed it to mention the assert.

> 
> > Source/WebKit2/ChangeLog:8
> > +        Don't call didPerformClientRedirect or didPerformServerRedirect when source or destination URL string
> > +        is empty or null.
> 
> If the bug title described an actual problem, your ChangeLog might become more informative.

Added some more detail to the ChangeLog.

[Brian Weinstein]

Created attachment 106801 [details]
[PATCH] Fix + Test + Better ChangeLog

[Brian Weinstein]

Landed in r94812.

[Adam Roben (:aroben)]

Comment on attachment 106801 [details]
[PATCH] Fix + Test + Better ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=106801&action=review

> Source/WebKit2/ChangeLog:3
> +        WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string

It would be even better to describe this in terms of what a client app does that results in the assertion.

> Source/WebKit2/ChangeLog:11
> +        Don't call didPerformClientRedirect or didPerformServerRedirect when source or destination URL string
> +        is empty or null.
> +        
> +        If we call didPerformClientRedirect or didPerformServerRedirect when the source or destination is null,
> +        it causes an assert in WKURLCF::WKURLCopyCFURL when we try to convert the WKURLRef into a CFURLRef.

This still doesn't explain why it's OK not to call the callbacks.