Summary: | Crashes in WebCore::ReplaceSelectionCommand::doApply | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinya Kawanaka <shinyak> | ||||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | rniwa, shinyak, tkent, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 67668 | ||||||||||
Attachments: |
|
Description
Shinya Kawanaka
2011-09-07 23:40:31 PDT
Created attachment 106700 [details]
Patch
Comment on attachment 106700 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106700&action=review > LayoutTests/ChangeLog:11 > + * editing/inserting/insert-replaceselection-crash-expected.txt: Added. > + * editing/inserting/insert-replaceselection-crash.html: Added. It's better, but we had better describe a test case, rather than a crash location. How about insert-without-enclosing-block.html? > Source/WebCore/ChangeLog:10 > + Test: editing/inserting/insert-67668-crash.html Need to update. Comment on attachment 106700 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106700&action=review > LayoutTests/editing/inserting/insert-replaceselection-crash.html:7 > +var sel = window.getSelection(); > + > +sel.setPosition(div, 0); It seems redundant to declare sel. Created attachment 106703 [details]
Patch
Reflected the above comments. Comment on attachment 106703 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106703&action=review > LayoutTests/ChangeLog:11 > + * editing/inserting/insert-replaceselection-crash-expected.txt: Added. > + * editing/inserting/insert-replaceselection-crash.html: Added. You should rename the test as tkent suggested. (In reply to comment #6) > (From update of attachment 106703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106703&action=review > > > LayoutTests/ChangeLog:11 > > + * editing/inserting/insert-replaceselection-crash-expected.txt: Added. > > + * editing/inserting/insert-replaceselection-crash.html: Added. > > You should rename the test as tkent suggested. Oops, sorry. I'll fix them soon. Created attachment 106706 [details]
Patch
Comment on attachment 106706 [details] Patch Clearing flags on attachment: 106706 Committed r94793: <http://trac.webkit.org/changeset/94793> All reviewed patches have been landed. Closing bug. |