Summary: | Refactor hyphen measurement | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ned Holbrook <ned> | ||||||
Component: | Text | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Enhancement | CC: | webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Ned Holbrook
2011-09-07 12:58:13 PDT
Created attachment 106623 [details]
Proposed changes.
Comment on attachment 106623 [details] Proposed changes. View in context: https://bugs.webkit.org/attachment.cgi?id=106623&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:485 > + RenderStyle* style = renderer->style(); > + const AtomicString& hyphenString = style->hyphenString(); > + return font.width(RenderBlock::constructTextRun(renderer, font, hyphenString.string(), style)); Not sure these local variables help make this more readable. Created attachment 106660 [details]
Changes per review.
How about we split the difference so as to avoid doubly dereferencing |renderer|?
Comment on attachment 106660 [details] Changes per review. Clearing flags on attachment: 106660 Committed r94778: <http://trac.webkit.org/changeset/94778> All reviewed patches have been landed. Closing bug. |