Bug 67728

Summary: Refactor hyphen measurement
Product: WebKit Reporter: Ned Holbrook <ned>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed changes.
darin: review+
Changes per review. none

Ned Holbrook
Reported 2011-09-07 12:58:13 PDT
It would be nice to avoid duplicated code in RenderBlockLineLayout.cpp by adding a helper function to measure the hyphen string.
Attachments
Proposed changes. (3.50 KB, patch)
2011-09-07 13:00 PDT, Ned Holbrook 		darin: review+
DetailsFormatted DiffDiff
Changes per review. (3.45 KB, patch)
2011-09-07 15:33 PDT, Ned Holbrook 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ned Holbrook
Comment 1 2011-09-07 13:00:19 PDT
Created attachment 106623 [details] Proposed changes.
Darin Adler
Comment 2 2011-09-07 14:02:14 PDT
Comment on attachment 106623 [details] Proposed changes. View in context: https://bugs.webkit.org/attachment.cgi?id=106623&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:485 > + RenderStyle* style = renderer->style(); > + const AtomicString& hyphenString = style->hyphenString(); > + return font.width(RenderBlock::constructTextRun(renderer, font, hyphenString.string(), style)); Not sure these local variables help make this more readable.
Ned Holbrook
Comment 3 2011-09-07 15:33:38 PDT
Created attachment 106660 [details] Changes per review. How about we split the difference so as to avoid doubly dereferencing |renderer|?
WebKit Review Bot
Comment 4 2011-09-08 12:17:49 PDT
Comment on attachment 106660 [details] Changes per review. Clearing flags on attachment: 106660 Committed r94778: <http://trac.webkit.org/changeset/94778>
WebKit Review Bot
Comment 5 2011-09-08 12:17:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.