Bug 67687

Summary:

REGRESSION(r94593): textfield-overflow-by-value-update.html fails

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Layout and Rendering

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, dglazkov, hyatt, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
rebaseline the test	none

Ryosuke Niwa

Reported 2011-09-06 17:45:00 PDT

After http://trac.webkit.org/changeset/94593, fast/forms/textfield-overflow-by-value-update.html started failing: http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r94596%20(2025)/fast/forms/textfield-overflow-by-value-update-pretty-diff.html http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20(Tests)/builds/2025 http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20(Tests)/builds/2023 I've manually bisected the builds to determine the revision.

Attachments
rebaseline the test (1.35 KB, patch) 2011-09-06 18:51 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2011-09-06 17:52:58 PDT

The test depends on a JS file in the directory, but the contents of the failing test are: <!DOCTYPE html> <head> <script src="resources/common.js"></script> <style> input { -webkit-appearance: none; font-size: 32px; height: 0px; width: 100px; border-width: 0px; } </style> <body>  <input id="textfield"> <script> $('textfield').offsetTop; $('textfield').value = "FAIL"; </script> </body>

Ryosuke Niwa

Comment 2 2011-09-06 17:59:38 PDT

Note this test is added by tkent in http://trac.webkit.org/changeset/90379.

Kent Tamura

Comment 3 2011-09-06 18:18:39 PDT

The text result is not important for this test. If the pixel result is not changed, let's do rebaseline.

Dave Hyatt

Comment 4 2011-09-06 18:20:21 PDT

This actually doesn't fail for me in ToT Safari.

Ryosuke Niwa

Comment 5 2011-09-06 18:25:29 PDT

(In reply to comment #3) > The text result is not important for this test. If the pixel result is not changed, let's do rebaseline. (In reply to comment #4) > This actually doesn't fail for me in ToT Safari. Okay, that sounds great! I'm going to build ToT and run the pixel test to confirm that there's no regression.

Ryosuke Niwa

Comment 6 2011-09-06 18:49:13 PDT

I have confirmed that the pixel test still passes. I'm going to rebaseline it.

Ryosuke Niwa

Comment 7 2011-09-06 18:51:29 PDT

Created attachment 106532 [details] rebaseline the test

Kent Tamura

Comment 8 2011-09-06 19:24:00 PDT

The test has failed on - "SnowLeopard Intel Debug (Tests)" bot - "Leopard Intel Debug (Tests)" bot The test hasn't failed on - "SnowLeopard Intel Release (tests)" bot - Chromium ToT bots on chromium.org - Chromium ToT bots on webkit.org - my local debug WebKit ToT on Snow Leopard

Ryosuke Niwa

Comment 9 2011-09-06 19:26:51 PDT

(In reply to comment #8) > The test has failed on > - "SnowLeopard Intel Debug (Tests)" bot > - "Leopard Intel Debug (Tests)" bot > > The test hasn't failed on > - "SnowLeopard Intel Release (tests)" bot > - Chromium ToT bots on chromium.org > - Chromium ToT bots on webkit.org > - my local debug WebKit ToT on Snow Leopard Mn... You're right. That is very weird.

Ryosuke Niwa

Comment 10 2011-09-08 12:02:16 PDT

It seems like the test is no longer failing.

Note You need to log in before you can comment on or make changes to this bug.