Bug 67681

Summary: REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: FramesAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, dglazkov, isherman, jhawkins, morrita, tkent, zelidrag
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
DRT test
none
fixes the bug
none
added PASS/FAIL per ap's request none

Description Ryosuke Niwa 2011-09-06 15:54:17 PDT
Created attachment 106508 [details]
DRT test

When HTMLInputElement::setValue, we don't reset m_suggestedValue until after updateInnerTextValue is called.  As a result, the inner text value is not updated to new value.
Comment 1 Ryosuke Niwa 2011-09-06 16:03:36 PDT
Come to think of it, this is yet another regression from r94274 :(.
Comment 2 Ryosuke Niwa 2011-09-06 16:05:26 PDT
(In reply to comment #1)
> Come to think of it, this is yet another regression from r94274 :(.

To my defense, there were no tests for suggested values prior to http://trac.webkit.org/changeset/94586.
Comment 3 Ryosuke Niwa 2011-09-06 16:30:02 PDT
Created attachment 106514 [details]
fixes the bug
Comment 4 Ryosuke Niwa 2011-09-06 17:11:53 PDT
Created attachment 106522 [details]
added PASS/FAIL per ap's request
Comment 5 Kent Tamura 2011-09-06 18:38:38 PDT
Comment on attachment 106522 [details]
added PASS/FAIL per ap's request

ok
Comment 6 Ryosuke Niwa 2011-09-06 18:39:46 PDT
(In reply to comment #5)
> (From update of attachment 106522 [details])
> ok

Thanks!
Comment 7 Ryosuke Niwa 2011-09-06 21:42:27 PDT
Comment on attachment 106522 [details]
added PASS/FAIL per ap's request

Clearing flags on attachment: 106522

Committed r94637: <http://trac.webkit.org/changeset/94637>
Comment 8 Ryosuke Niwa 2011-09-06 21:42:31 PDT
All reviewed patches have been landed.  Closing bug.