Bug 67681

Summary: REGRESSION(r94274): The inner text value of an input element is not updated when input.value is set
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: FramesAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, dglazkov, isherman, jhawkins, morrita, tkent, zelidrag
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
DRT test
none
fixes the bug
none
added PASS/FAIL per ap's request none

Ryosuke Niwa
Reported 2011-09-06 15:54:17 PDT
Created attachment 106508 [details] DRT test When HTMLInputElement::setValue, we don't reset m_suggestedValue until after updateInnerTextValue is called. As a result, the inner text value is not updated to new value.
Attachments
DRT test (1.28 KB, text/html)
2011-09-06 15:54 PDT, Ryosuke Niwa 		no flags
Details
fixes the bug (5.12 KB, patch)
2011-09-06 16:30 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
added PASS/FAIL per ap's request (5.33 KB, patch)
2011-09-06 17:11 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-09-06 16:03:36 PDT
Come to think of it, this is yet another regression from r94274 :(.
Ryosuke Niwa
Comment 2 2011-09-06 16:05:26 PDT
(In reply to comment #1) > Come to think of it, this is yet another regression from r94274 :(. To my defense, there were no tests for suggested values prior to http://trac.webkit.org/changeset/94586.
Ryosuke Niwa
Comment 3 2011-09-06 16:30:02 PDT
Created attachment 106514 [details] fixes the bug
Ryosuke Niwa
Comment 4 2011-09-06 17:11:53 PDT
Created attachment 106522 [details] added PASS/FAIL per ap's request
Kent Tamura
Comment 5 2011-09-06 18:38:38 PDT
Comment on attachment 106522 [details] added PASS/FAIL per ap's request ok
Ryosuke Niwa
Comment 6 2011-09-06 18:39:46 PDT
(In reply to comment #5) > (From update of attachment 106522 [details]) > ok Thanks!
Ryosuke Niwa
Comment 7 2011-09-06 21:42:27 PDT
Comment on attachment 106522 [details] added PASS/FAIL per ap's request Clearing flags on attachment: 106522 Committed r94637: <http://trac.webkit.org/changeset/94637>
Ryosuke Niwa
Comment 8 2011-09-06 21:42:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.