Bug 67680

Summary: WebVTTParser/Tokenizer introduce layering violation in WebCore/platform
Product: WebKit Reporter: Sam Weinig <sam>
Component: MediaAssignee: Anna Cavender <annacc>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, levin, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
moving files none

Sam Weinig
Reported 2011-09-06 15:48:14 PDT
The files in WebCore/platform/track/ introduce a layering violation by referencing files out side of WebCore/platform in WebCore, such as HTMLElement.h, Document.h, ProcessingInstruction.h, MarkupTokenizerBase.h, etc.
Attachments
moving files (98.78 KB, patch)
2011-09-06 19:13 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anna Cavender
Comment 1 2011-09-06 19:13:10 PDT
Created attachment 106533 [details] moving files
WebKit Review Bot
Comment 2 2011-09-06 19:16:31 PDT
Attachment 106533 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1 Source/WebCore/html/track/WebVTTTokenizer.cpp:86: Non-label code inside switch statements should be indented. [whitespace/indent] [4] Source/WebCore/html/track/CueParserPrivate.h:49: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 3 2011-09-06 19:55:30 PDT
Sorry for leading you astray earlier.
Anna Cavender
Comment 4 2011-09-07 07:54:41 PDT
Comment on attachment 106533 [details] moving files No worries, thanks for the review.
WebKit Review Bot
Comment 5 2011-09-07 11:49:43 PDT
Comment on attachment 106533 [details] moving files Clearing flags on attachment: 106533 Committed r94694: <http://trac.webkit.org/changeset/94694>
WebKit Review Bot
Comment 6 2011-09-07 11:50:00 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 7 2011-09-07 12:10:45 PDT
This patch broke Mac builds :( Why did you not edit xcodeproj?
Ryosuke Niwa
Comment 8 2011-09-07 12:36:53 PDT
Fixed Mac build in http://trac.webkit.org/changeset/94699.
Note You need to log in before you can comment on or make changes to this bug.