Bug 67677

Summary: offsetFromRoot optimization is disabled after r93837
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Trivial fix: Readd the parameter (that should NEVER have gone), unfortunately no test. simon.fraser: review+, jchaffraix: commit-queue+

Julien Chaffraix
Reported 2011-09-06 15:14:01 PDT
I perf-tested a previous patch (which prompted the importance of passing the argument to computeRepaintRect) but the patch that landed disabled the optimization! This mistake basically re-introduce a O(n^2) in updateLayerPositions that the optimization was preventing.
Attachments
Trivial fix: Readd the parameter (that should NEVER have gone), unfortunately no test. (4.03 KB, patch)
2011-09-06 15:40 PDT, Julien Chaffraix 		simon.fraser: review+
jchaffraix: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-09-06 15:40:38 PDT
Created attachment 106502 [details] Trivial fix: Readd the parameter (that should NEVER have gone), unfortunately no test.
Julien Chaffraix
Comment 2 2011-09-07 13:08:42 PDT
Comment on attachment 106502 [details] Trivial fix: Readd the parameter (that should NEVER have gone), unfortunately no test. Thanks Simon!
Julien Chaffraix
Comment 3 2011-09-07 18:37:43 PDT
Committed r94741: <http://trac.webkit.org/changeset/94741>
Note You need to log in before you can comment on or make changes to this bug.