Bug 67648 – Move SelectorChecker out from the CSSStyleSelector scope

• Component: CSS
• Status: RESOLVED FIXED

[Antti Koivisto]

SelectorChecker is more than 1000 lines of code, it deserves a file of its own.

[Sam Weinig]

But has it earned it?

[Antti Koivisto]

Created attachment 106425 [details]
patch, with mac build files only

[Antti Koivisto]

Oh, we are going to make it earn it.

[Antti Koivisto]

Created attachment 106464 [details]
patch, with build files

[WebKit Review Bot]

Attachment 106464 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Last 3072 characters of output:
[5]
Source/WebCore/css/CSSStyleSelector.h:195:  The parameter name "rule" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSelector.h:225:  The parameter name "decl" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSelector.h:250:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/css/CSSStyleSelector.h:251:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/css/CSSStyleSelector.h:320:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/CSSStyleSelector.h:322:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/SelectorChecker.h:55:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/SelectorChecker.h:78:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/SelectorChecker.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/SelectorChecker.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/SelectorChecker.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/SelectorChecker.cpp:57:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/SelectorChecker.cpp:242:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/SelectorChecker.cpp:315:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/SelectorChecker.cpp:373:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/SelectorChecker.cpp:472:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/SelectorChecker.cpp:599:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/SelectorChecker.cpp:604:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/css/SelectorChecker.cpp:931:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/SelectorChecker.cpp:995:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/SelectorChecker.cpp:1101:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/css/SelectorChecker.cpp:1111:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 27 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 106464 [details]
patch, with build files

Attachment 106464 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9595699

[WebKit Review Bot]

Comment on attachment 106464 [details]
patch, with build files

Attachment 106464 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9595697

[Gyuyoung Kim]

Comment on attachment 106464 [details]
patch, with build files

Attachment 106464 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9593835

[Gustavo Noronha (kov)]

Comment on attachment 106464 [details]
patch, with build files

Attachment 106464 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9593834

[Sam Weinig]

If you make it build, I will r+ it.  rs=me.

[WebKit Review Bot]

Comment on attachment 106464 [details]
patch, with build files

Attachment 106464 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9602051

[Antti Koivisto]

(In reply to comment #10)
> If you make it build, I will r+ it.  rs=me.

Build? Standards are getting so tough these days.

[Antti Koivisto]

Created attachment 106488 [details]
patch for bots to chew

[Antti Koivisto]

Created attachment 106553 [details]
for bots

[WebKit Review Bot]

Attachment 106553 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/css/CSSStyleSelector.h:91:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/css/CSSStyleSelector.h:103:  The parameter name "e" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSelector.h:105:  The parameter name "list" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSelector.h:107:  The parameter name "pseudo" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSStyleSelector.h:107:  The parameter name "e" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 6 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 106553 [details]
for bots

Attachment 106553 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9607240

[Antti Koivisto]

Created attachment 106557 [details]
another one

[WebKit Review Bot]

Attachment 106557 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/css/CSSStyleSelector.h:91:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 106557 [details]
another one

Attachment 106557 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9603485

[Antti Koivisto]

http://trac.webkit.org/changeset/94656