| Summary: | [chromium] REGRESSION(94353): requestAnimationFrame not throttled in compositing path | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
| Component: | New Bugs | Assignee: | Nat Duca <nduca> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | enne, fishd, jamesr, nduca, vangelis, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
James Robinson
2011-09-05 18:00:33 PDT
Locally confirmed that it's http://trac.webkit.org/changeset/94353. I'm not really sure how... Oy! Well I guess we know what I'm doing on Tuesday then. :) Created attachment 106452 [details]
Patch
Comment on attachment 106452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106452&action=review > Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:91 > + commitIfNeeded(false); actually we don't want to do layout here either. it's the responsibility of the caller to WebWidget::paint() to call animateAndLayout() before calling this function > Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:237 > + if (!alreadyCalledLayout) > + m_layerTreeHost->animateAndLayout(frameBeginTime); i think you can just delete this completely > i think you can just delete this completely
I did this because we're going to have to eventually invert that. But, I'll do as you wish.
Eventually we'll need it, but not for compositeAndReadback(). That path will not. Created attachment 106456 [details]
Okay
Committed r94587: <http://trac.webkit.org/changeset/94587> |