Bug 67596

Summary: Rebaseline for bug 65583 (path based border radius drawing on skia) part 1
Product: WebKit Reporter: Ben Wells <benwells>
Component: New BugsAssignee: Ben Wells <benwells>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, mikelawther, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch with no deltas for binary files none

Description Ben Wells 2011-09-05 04:06:56 PDT
Rebaseline for bug 65583 (path based border radius drawing on skia)
Comment 1 Ben Wells 2011-09-05 17:34:49 PDT
Created attachment 106368 [details]
Patch
Comment 2 Ben Wells 2011-09-05 17:43:44 PDT
cq left off intentionally, if review is good will land in Sydney time zone hours.
Comment 3 James Robinson 2011-09-05 18:38:56 PDT
Comment on attachment 106368 [details]
Patch

Something's wrong with these, the diffs aren't showing up properly:

LayoutTests/platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png
LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png
LayoutTests/platform/chromium-win/fast/css/color-leakage-expected.png

Otherwise this looks good.
Comment 4 James Robinson 2011-09-05 18:40:54 PDT
Also filed https://bugs.webkit.org/show_bug.cgi?id=67623
Comment 5 Ben Wells 2011-09-05 22:50:13 PDT
Have submitted bug 67628 to fix what looks like a bug in the pretty patch generator which stops these diffs showing up. Hopefully that will land smoothly and then I can get back to the rebaselines.
Comment 6 Ben Wells 2011-09-06 18:26:13 PDT
Created attachment 106529 [details]
Patch with no deltas for binary files
Comment 7 Ben Wells 2011-09-06 18:30:05 PDT
Comment on attachment 106529 [details]
Patch with no deltas for binary files

This patch shows up properly in the pretty format.
Comment 8 Kenneth Russell 2011-09-06 18:52:41 PDT
Comment on attachment 106529 [details]
Patch with no deltas for binary files

The new baselines look great. fast/css/nested-rounded-corners-expected.png in particular looks much improved.
Comment 9 WebKit Review Bot 2011-09-06 19:35:04 PDT
Comment on attachment 106529 [details]
Patch with no deltas for binary files

Clearing flags on attachment: 106529

Committed r94628: <http://trac.webkit.org/changeset/94628>
Comment 10 WebKit Review Bot 2011-09-06 19:35:14 PDT
All reviewed patches have been landed.  Closing bug.