Bug 67596

Summary: Rebaseline for bug 65583 (path based border radius drawing on skia) part 1
Product: WebKit Reporter: Ben Wells <benwells>
Component: New BugsAssignee: Ben Wells <benwells>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, mikelawther, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch with no deltas for binary files none

Ben Wells
Reported 2011-09-05 04:06:56 PDT
Rebaseline for bug 65583 (path based border radius drawing on skia)
Attachments
Patch (1.66 MB, patch)
2011-09-05 17:34 PDT, Ben Wells 		no flags
DetailsFormatted DiffDiff
Patch with no deltas for binary files (1.66 MB, patch)
2011-09-06 18:26 PDT, Ben Wells 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ben Wells
Comment 1 2011-09-05 17:34:49 PDT
Created attachment 106368 [details] Patch
Ben Wells
Comment 2 2011-09-05 17:43:44 PDT
cq left off intentionally, if review is good will land in Sydney time zone hours.
James Robinson
Comment 3 2011-09-05 18:38:56 PDT
Comment on attachment 106368 [details] Patch Something's wrong with these, the diffs aren't showing up properly: LayoutTests/platform/chromium-win/css2.1/t0805-c5517-brdr-s-00-c-expected.png LayoutTests/platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png LayoutTests/platform/chromium-win/fast/css/color-leakage-expected.png Otherwise this looks good.
James Robinson
Comment 4 2011-09-05 18:40:54 PDT
Also filed https://bugs.webkit.org/show_bug.cgi?id=67623
Ben Wells
Comment 5 2011-09-05 22:50:13 PDT
Have submitted bug 67628 to fix what looks like a bug in the pretty patch generator which stops these diffs showing up. Hopefully that will land smoothly and then I can get back to the rebaselines.
Ben Wells
Comment 6 2011-09-06 18:26:13 PDT
Created attachment 106529 [details] Patch with no deltas for binary files
Ben Wells
Comment 7 2011-09-06 18:30:05 PDT
Comment on attachment 106529 [details] Patch with no deltas for binary files This patch shows up properly in the pretty format.
Kenneth Russell
Comment 8 2011-09-06 18:52:41 PDT
Comment on attachment 106529 [details] Patch with no deltas for binary files The new baselines look great. fast/css/nested-rounded-corners-expected.png in particular looks much improved.
WebKit Review Bot
Comment 9 2011-09-06 19:35:04 PDT
Comment on attachment 106529 [details] Patch with no deltas for binary files Clearing flags on attachment: 106529 Committed r94628: <http://trac.webkit.org/changeset/94628>
WebKit Review Bot
Comment 10 2011-09-06 19:35:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.