| Summary: | [EFL] Move assignment of some variables out of loop for ewk_tiled_backing_store. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | KwangHyuk <hyuki.kim> | ||||||||||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | gyuyoung.kim, leandro, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Other | ||||||||||||||||
| OS: | Linux | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
KwangHyuk
2011-09-05 00:46:39 PDT
Created attachment 106312 [details]
Patch.
Comment on attachment 106312 [details]
Patch.
LGTM. However, are there any test cases in order to check if this patch makes side effects?
> LGTM. However, are there any test cases in order to check if this patch makes side effects?
I believe that scroll via EWebLauncher would be enough for test usage. :)
However, there was no logic change because this is just for small optimization to reduce repetition of ineffective variable assignment inside of loop.
LGTM too. Comment on attachment 106312 [details]
Patch.
I really hope you can move over to using the Qt tiling implementation. That is quite easy to understand and written in C++
Hi, Kenneth, I am thinking that webkit EFL tiling implementation should be maintained and optimized too until we will be able to get advantage from qt tiling implementation. And moreover, I believe that both two can be mixed too. Fortunately, One of our guys is trying to let WebCore inside backing store logic be integrated with webkit efl. You can see the patch set that he will contribute soon. :-) Created attachment 111936 [details]
Patch rebased.
Created attachment 111937 [details]
patch rebased.
Created attachment 112140 [details] Patch rebase. Refactoring code from https://bugs.webkit.org/show_bug.cgi?id=69988 was migrated. Created attachment 112142 [details] Patch rebased. Refactoring code from https://bugs.webkit.org/show_bug.cgi?id=69988 was migrated. Attachment 112140 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1058: Tab found; better to use spaces [whitespace/tab] [1]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 112142 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1058: Tab found; better to use spaces [whitespace/tab] [1]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 112143 [details]
Remove tab.
Comment on attachment 112143 [details] Remove tab. LGTM. I missed to change these variables on Bug 69988. Comment on attachment 112143 [details]
Remove tab.
Looks reasonable.
Comment on attachment 112143 [details] Remove tab. Clearing flags on attachment: 112143 Committed r98419: <http://trac.webkit.org/changeset/98419> All reviewed patches have been landed. Closing bug. |