Bug 67550

Summary: split overrideSize into overrideHeight and overrideWidth
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, hyatt, jamesr, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Ojan Vafai
Reported 2011-09-02 19:40:49 PDT
split overrideSize into overrideHeight and overrideWidth
Attachments
Patch (16.63 KB, patch)
2011-09-02 19:51 PDT, Ojan Vafai 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-09-02 19:51:02 PDT
Created attachment 106241 [details] Patch
Tony Chang
Comment 2 2011-09-06 10:51:58 PDT
Comment on attachment 106241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106241&action=review > Source/WebCore/rendering/RenderBox.cpp:1593 > #if ENABLE(CSS3_FLEXBOX) > // FIXME: Check direction once flex-direction is implemented. > - if (hasOverrideSize() && parent()->isFlexibleBox()) { > + if (hasOverrideWidth() && parent()->isFlexibleBox()) { > setLogicalWidth(overrideWidth()); > return; We can get rid of this #if block and use: if (hasOverrideWidth() && isFlexibleBoxIncludingDeprecated()) > Source/WebCore/rendering/RenderBox.h:250 > + void setOverrideHeight(const LayoutUnit); > + void setOverrideWidth(const LayoutUnit); Nit: I would drop the const here.
Ojan Vafai
Comment 3 2011-09-07 13:17:15 PDT
Committed r94706: <http://trac.webkit.org/changeset/94706>
Note You need to log in before you can comment on or make changes to this bug.