Bug 67432

Summary: implement -webkit-flex-order
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: eoconnor, hyatt, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tony Chang
Reported 2011-09-01 13:42:50 PDT
implement -webkit-flex-order
Attachments
Patch (18.93 KB, patch)
2011-09-01 13:46 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (19.49 KB, patch)
2011-09-02 09:27 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (20.02 KB, patch)
2011-09-21 11:06 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-09-01 13:46:22 PDT
Created attachment 106020 [details] Patch
Ojan Vafai
Comment 2 2011-09-01 14:33:33 PDT
Comment on attachment 106020 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106020&action=review Just a tiny nit from me. > LayoutTests/css3/flexbox/flex-order.html:9 > +.horizontal-box div { > + height: 30px; > + border: 0; The pixel output from this test would be easier to make sense of if there were some padding between the horizontal-boxen.
Tony Chang
Comment 3 2011-09-02 09:27:11 PDT
Created attachment 106140 [details] Patch
Tony Chang
Comment 4 2011-09-21 11:06:40 PDT
Created attachment 108184 [details] Patch
Tony Chang
Comment 5 2011-09-21 11:24:03 PDT
(In reply to comment #4) > Created an attachment (id=108184) [details] > Patch Rebased to after the logical positional fixes (just renames for this code).
WebKit Review Bot
Comment 6 2011-09-22 21:53:50 PDT
Comment on attachment 108184 [details] Patch Clearing flags on attachment: 108184 Committed r95783: <http://trac.webkit.org/changeset/95783>
WebKit Review Bot
Comment 7 2011-09-22 21:53:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.