Bug 67419

Summary: [Chromium/Skia] Use GraphicsContext3D::grContext() to create GrContext for accelerated drawing
Product: WebKit Reporter: Brian Salomon <bsalomon>
Component: PlatformAssignee: Brian Salomon <bsalomon>
Status: RESOLVED FIXED    
Severity: Normal CC: alokp, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Brian Salomon
Reported 2011-09-01 10:52:53 PDT
[Chromium/Skia] Use GraphicsContext3D::grContext() to create GrContext for accelerated drawing
Attachments
Patch (9.04 KB, patch)
2011-09-01 10:57 PDT, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Patch (9.05 KB, patch)
2011-09-01 11:23 PDT, Brian Salomon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brian Salomon
Comment 1 2011-09-01 10:57:01 PDT
Created attachment 105992 [details] Patch
Brian Salomon
Comment 2 2011-09-01 11:02:37 PDT
The code that creates a GrContext for accelerated drawing relied on removed code that set a default GrGLInterface when a WGC3D subclass was created. So GrContext creation failed. This change uses the existing GrContext creation code in GraphicsContext3D. This change fixes http://crbug.com/95044
James Robinson
Comment 3 2011-09-01 11:06:54 PDT
Comment on attachment 105992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105992&action=review > Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.h:97 > + LayerTextureUpdaterSkPicture(PassOwnPtr<LayerPainterChromium>); need explicit keyword on this c'tor
Brian Salomon
Comment 4 2011-09-01 11:23:37 PDT
Created attachment 105996 [details] Patch
Brian Salomon
Comment 5 2011-09-01 11:25:12 PDT
(In reply to comment #3) > (From update of attachment 105992 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=105992&action=review > > > Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.h:97 > > + LayerTextureUpdaterSkPicture(PassOwnPtr<LayerPainterChromium>); > > need explicit keyword on this c'tor Added in latest patch.
WebKit Review Bot
Comment 6 2011-09-01 12:27:56 PDT
Comment on attachment 105996 [details] Patch Clearing flags on attachment: 105996 Committed r94329: <http://trac.webkit.org/changeset/94329>
WebKit Review Bot
Comment 7 2011-09-01 12:28:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.