Bug 67387

Summary: [Chromium] Webfonts display bold in Windows
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: PlatformAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: evan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://crbug.com/94903
Attachments:
Description Flags
Patch none

Kenichi Ishibashi
Reported 2011-09-01 04:46:23 PDT
Chromium bug entry: http://crbug.com/94903 Chromium win port uses CreateFontIndirect() to create FontCustomPlatformData object for webfonts. A webfont could be wider (or narrower) than expected when the font's weight class isn't normal(400) because CreateFontIndirect() adjusts font weight according to LOGFONT.lfWeight. For webfonts, we should set LOGFONT.lfWeight to FW_DONTCARE, which means using a default weight.
Attachments
Patch (1.72 KB, patch)
2011-09-01 04:55 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2011-09-01 04:55:38 PDT
Created attachment 105942 [details] Patch
Kenichi Ishibashi
Comment 2 2011-09-01 05:01:59 PDT
I didn't come up with how to test for this patch because testing this patch requires a non-local font whose weight class isn't normal..
Kent Tamura
Comment 3 2011-09-02 02:35:27 PDT
Comment on attachment 105942 [details] Patch ok
Kenichi Ishibashi
Comment 4 2011-09-02 02:36:40 PDT
Comment on attachment 105942 [details] Patch Kent-san, Thank you for review!
WebKit Review Bot
Comment 5 2011-09-02 03:38:04 PDT
Comment on attachment 105942 [details] Patch Clearing flags on attachment: 105942 Committed r94400: <http://trac.webkit.org/changeset/94400>
WebKit Review Bot
Comment 6 2011-09-02 03:38:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.