Summary: | De-virtualize recalcStyle() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, hyatt, oliver, sam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Antti Koivisto
2011-09-01 01:59:54 PDT
Created attachment 105930 [details]
patch
Comment on attachment 105930 [details]
patch
this looks glorious. Your change highlights the greater problem of hacks around style recalculation. Adding those extra methods (and stealing a bit) from Node.h is a great motivator to fix this problem for realz. But... why are the EWS chipmunks so purple?
Created attachment 106105 [details]
tot patch for bots to chew
Attachment 106105 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/svg/SVGUseElement.h:67: The parameter name "change" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/svg/SVGUseElement.h:68: The parameter name "change" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 2 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 106105 [details] tot patch for bots to chew Attachment 106105 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9582601 New failing tests: svg/batik/text/textStyles.svg Couldn't see the bot reported test failure locally. |