Bug 67360

Summary: updateInnerTextValue should be moved into InputType
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: FormsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, dglazkov, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 66241, 67697, 67742    
Bug Blocks:    
Attachments:
Description Flags
work in progress none

Ryosuke Niwa
Reported 2011-08-31 22:57:22 PDT
HTMLInputElement::updateInnerTextValue added in the patch for the bug 66241 should be pushed into InputType.
Attachments
work in progress (12.40 KB, patch)
2011-09-06 15:50 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-09-06 15:50:41 PDT
Created attachment 106507 [details] work in progress There is a subtle bug that inner text value isn't updated when input.value is set.
Kent Tamura
Comment 2 2011-09-06 18:51:09 PDT
Comment on attachment 106507 [details] work in progress View in context: https://bugs.webkit.org/attachment.cgi?id=106507&action=review > Source/WebCore/html/TextInputType.cpp:53 > + // FIXME: should this be moved to TextFieldInputType? I think so. It looks a bug of the current code.
Ryosuke Niwa
Comment 3 2011-09-06 18:58:57 PDT
Comment on attachment 106507 [details] work in progress View in context: https://bugs.webkit.org/attachment.cgi?id=106507&action=review >> Source/WebCore/html/TextInputType.cpp:53 >> + // FIXME: should this be moved to TextFieldInputType? > > I think so. It looks a bug of the current code. Okay. Let me see if I can come up with a test.
Ryosuke Niwa
Comment 4 2011-11-07 18:58:49 PST
This has already been done elsewhere.
Note You need to log in before you can comment on or make changes to this bug.