Bug 67349

Summary: [Chromium] Rename PlatformBridge to PlatformSupport
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fishd: review+, webkit.review.bot: commit-queue-

Adam Barth
Reported 2011-08-31 17:51:30 PDT
[Chromium] Rename PlatformBridge to PlatformSupport
Attachments
Patch (198.46 KB, patch)
2011-08-31 17:53 PDT, Adam Barth 		fishd: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-08-31 17:53:07 PDT
Created attachment 105872 [details] Patch
WebKit Review Bot
Comment 2 2011-08-31 17:57:01 PDT
Attachment 105872 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/qt/PlatformSupport.h:75: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/qt/PlatformSupport.h:76: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/qt/PlatformSupport.h:91: The parameter name "npp" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 64 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2011-08-31 19:04:47 PDT
Comment on attachment 105872 [details] Patch Attachment 105872 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9582002
WebKit Review Bot
Comment 4 2011-08-31 23:12:13 PDT
Comment on attachment 105872 [details] Patch Attachment 105872 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9570900
Adam Barth
Comment 5 2011-08-31 23:22:40 PDT
Committed r94275: <http://trac.webkit.org/changeset/94275>
Note You need to log in before you can comment on or make changes to this bug.