Bug 67307

Summary: [Qt][Symbian] REGRESSION(93235) Missing .def update
Product: WebKit Reporter: Ademar Reis <ademar>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cshu, laszlo.gombos, webkit.review.bot
Priority: P2 Keywords: Qt, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fix none

Description Ademar Reis 2011-08-31 11:39:51 PDT 
r93235 introduces new methods to DumpRenderTreeSupportQt but the respective .def file was not updated, thus breaking the build on Symbian.

See error below:
"""
 compile    : Tools\DumpRenderTree\qt\ImageDiff.cpp  	[armv5_urel.rvct4_0]
 target     : epoc32\release\armv5\urel\DumpRenderTree.exe  	[armv5_urel.rvct4_0]
   Error: L6218E: Undefined symbol DumpRenderTreeSupportQt::resetInternalsObject(QWebFrame*) (referred from DumpRenderTreeQt.o).
   Error: L6218E: Undefined symbol DumpRenderTreeSupportQt::injectInternalsObject(QWebFrame*) (referred from DumpRenderTreeQt.o).
   Not enough information to list image symbols.
   Finished: 1 information, 0 warning and 2 error messages.
"""

An example of .def file udpate: http://trac.webkit.org/changeset/89621
Comment 1 jade han 2011-09-02 15:34:34 PDT 
Created attachment 106208 [details]
fix
Comment 2 Laszlo Gombos 2011-09-02 15:38:36 PDT 
Comment on attachment 106208 [details]
fix

Looks good to me. Thanks !
Comment 3 WebKit Review Bot 2011-09-02 16:38:21 PDT 
Comment on attachment 106208 [details]
fix

Clearing flags on attachment: 106208

Committed r94462: <http://trac.webkit.org/changeset/94462>
Comment 4 WebKit Review Bot 2011-09-02 16:38:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ademar Reis 2011-09-05 06:31:43 PDT 
Revision r94462 cherry-picked into qtwebkit-2.2 with commit 52abba5 <http://gitorious.org/webkit/qtwebkit/commit/52abba5>