Bug 67189

Summary: [Qt][WK2] Make sure that the visible content rect and the content scale get to the web process in one single message.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, kbalazs, kenneth, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kenneth: review+

Jocelyn Turcotte
Reported 2011-08-30 02:45:38 PDT
[Qt][WK2] Make sure that the visible content rect and the content scale get to the web process in one single message.
Attachments
Patch (22.37 KB, patch)
2011-08-30 03:13 PDT, Jocelyn Turcotte 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2011-08-30 03:13:04 PDT
Created attachment 105608 [details] Patch
WebKit Review Bot
Comment 2 2011-08-30 03:16:05 PDT
Attachment 105608 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/qt/qtouchwebview.cpp:50: QTouchWebViewPrivate::_q_viewportUpdated is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qtouchwebview_p.h:38: _q_viewportUpdated is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kenneth Rohde Christiansen
Comment 3 2011-08-30 03:28:49 PDT
Comment on attachment 105608 [details] Patch very nice
Jocelyn Turcotte
Comment 4 2011-09-07 09:39:51 PDT
Committed r94673: <http://trac.webkit.org/changeset/94673>
Balazs Kelemen
Comment 5 2011-09-07 10:15:13 PDT
http/tests/cache/history-only-cached-subresource-loads.html started to fail after this: http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r94673%20(11431)/results.html
Balazs Kelemen
Comment 6 2011-09-07 10:22:25 PDT
(In reply to comment #5) > http/tests/cache/history-only-cached-subresource-loads.html started to fail after this: > http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r94673%20(11431)/results.html The failure has disappeared in the next bot build which was r94675.
Note You need to log in before you can comment on or make changes to this bug.