Bug 67168

Summary: Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 67291    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Tony Chang
Reported 2011-08-29 16:55:26 PDT
Remove webcore_bindings (including DerivedSources##.cpp) from the critical path
Attachments
Patch (2.68 KB, patch)
2011-08-29 17:01 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (2.91 KB, patch)
2011-08-31 10:53 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-08-29 17:01:43 PDT
Created attachment 105547 [details] Patch
Tony Chang
Comment 2 2011-08-30 09:34:36 PDT
Committed r94082: <http://trac.webkit.org/changeset/94082>
Alexander Pavlov (apavlov)
Comment 3 2011-08-31 07:54:19 PDT
This change breaks trunk Chromium Mac builders on a WebKit roll (strangely, it does not affect the canaries). I attempted a fix but it was not enough. I guess all the source-generating dependencies should be moved from webcore_bindings into webcore_remaining (like my attempt you can see at http://trac.webkit.org/changeset/94176/trunk/Source/WebCore/WebCore.gyp/WebCore.gyp). The second time, it seems, the "injected_script_source"-generated files were missing. Unfortunately, I could not afford another cycle to leave the Chromium trunk more than 1 day and 100+ revisions of WebKit behind, so I rolled out this change.
Tony Chang
Comment 4 2011-08-31 10:53:48 PDT
Created attachment 105793 [details] Patch
Tony Chang
Comment 5 2011-08-31 10:55:47 PDT
Take 2 of the patch: I added debugger_script_source, injected_script_source, and inspector_protocol_sources as dependencies of webcore_prerequisites because they also generate files that we try to compile. I manually verified on a mac that a clobber build without this change fails and a clobber build with this change succeeds.
WebKit Review Bot
Comment 6 2011-08-31 14:11:53 PDT
Comment on attachment 105793 [details] Patch Clearing flags on attachment: 105793 Committed r94232: <http://trac.webkit.org/changeset/94232>
WebKit Review Bot
Comment 7 2011-08-31 14:12:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.