Bug 67159

Summary:

[Qt] QTouchWebView url property test missing

Product:

WebKit

Reporter:

Gopal Raghavan <gopal.1.raghavan>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
url property test for TouchWebView	none

Gopal Raghavan

Reported 2011-08-29 15:41:07 PDT

Need property test for url in QTouchWebView. Very similar to https://bugs.webkit.org/show_bug.cgi?id=67155

Attachments
url property test for TouchWebView (1.49 KB, patch) 2011-08-29 15:44 PDT, Gopal Raghavan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gopal Raghavan

Comment 1 2011-08-29 15:44:32 PDT

Created attachment 105534 [details] url property test for TouchWebView Just realized we need a similar test as 67155 for QTouchWebView.

Gopal Raghavan

Comment 2 2011-08-29 15:45:12 PDT

********* Start testing of tst_QTouchWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QTouchWebView::initTestCase() PASS : tst_QTouchWebView::accessPage() PASS : tst_QTouchWebView::navigationActionsStatusAtStartup() PASS : tst_QTouchWebView::cleanupTestCase() Totals: 4 passed, 0 failed, 0 skipped ********* Finished testing of tst_QTouchWebView ********* ********* Start testing of tst_QDesktopWebView ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : tst_QDesktopWebView::initTestCase() PASS : tst_QDesktopWebView::navigationActionsStatusAtStartup() QWARN : tst_QDesktopWebView::stopActionEnabledAfterLoadStarted() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : tst_QDesktopWebView::stopActionEnabledAfterLoadStarted() PASS : tst_QDesktopWebView::cleanupTestCase() Totals: 4 passed, 0 failed, 0 skipped ********* Finished testing of tst_QDesktopWebView ********* ********* Start testing of qmltests ********* Config: Using QTest library 5.0.0, Qt 5.0.0 PASS : DesktopWebViewNavigationPolicyForUrl::initTestCase() QWARN : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() QObject::startTimer: timers cannot be started from another thread PASS : DesktopWebViewNavigationPolicyForUrl::test_ignorePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::test_usePolicy() PASS : DesktopWebViewNavigationPolicyForUrl::cleanupTestCase() PASS : DesktopWebViewProperties::initTestCase() PASS : DesktopWebViewProperties::test_title() PASS : DesktopWebViewProperties::cleanupTestCase() PASS : TouchWebViewProperties::initTestCase() QWARN : TouchWebViewProperties::test_title() QSocketNotifier: socket notifiers cannot be enabled from another thread PASS : TouchWebViewProperties::test_title() PASS : TouchWebViewProperties::test_url() PASS : TouchWebViewProperties::cleanupTestCase() Totals: 11 passed, 0 failed, 0 skipped ********* Finished testing of qmltests ********* ********************************************************************** ** TOTALS: 31 passed, 0 failed, 0 skipped ** **********************************************************************

Noam Rosenthal

Comment 3 2011-08-29 15:47:23 PDT

Comment on attachment 105534 [details] url property test for TouchWebView LGTM

WebKit Review Bot

Comment 4 2011-08-29 16:47:36 PDT

Comment on attachment 105534 [details] url property test for TouchWebView Clearing flags on attachment: 105534 Committed r94033: <http://trac.webkit.org/changeset/94033>

WebKit Review Bot

Comment 5 2011-08-29 16:47:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.