Bug 67156

Summary: Add HAVE(VASPRINTF) macro to test for vasprintf() support
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Web Template FrameworkAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2011-08-29 15:06:22 PDT
Currently in XMLDocumentParser::error() (http://trac.webkit.org/browser/trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp?rev=93638#L941) we hardcode compiler-specific testing for vasprintf() support. Instead, we should abstract this decision into a HAVE(VASPRINTF) macro so as to reduce duplicate code in XMLDocumentParser::error() as well as to centralize a definition for vasprintf() support. This would also make testing for vasprintf() support similar to testing for strnstr() support.
Attachments
Patch (2.82 KB, patch)
2011-08-29 15:22 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2011-08-29 15:22:20 PDT
Created attachment 105530 [details] Patch No change in functionality.
WebKit Review Bot
Comment 2 2011-08-29 22:00:53 PDT
Comment on attachment 105530 [details] Patch Clearing flags on attachment: 105530 Committed r94044: <http://trac.webkit.org/changeset/94044>
WebKit Review Bot
Comment 3 2011-08-29 22:00:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.