Bug 67123

Summary: [Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API DEFINE in WebKit2
Product: WebKit Reporter: Pierre Rossi <pierre.rossi>
Component: Plug-insAssignee: Pierre Rossi <pierre.rossi>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Pierre Rossi
Reported 2011-08-29 05:46:02 PDT
If that define is set to 0, there will be things missing in WebCore. :/
Attachments
Patch (1.26 KB, patch)
2011-08-29 05:56 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Patch (1.26 KB, patch)
2011-08-29 07:57 PDT, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pierre Rossi
Comment 1 2011-08-29 05:56:40 PDT
Created attachment 105482 [details] Patch
Andreas Kling
Comment 2 2011-08-29 06:09:50 PDT
Comment on attachment 105482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105482&action=review Looks sane. > Source/WebKit2/ChangeLog:3 > + [Qt] NPAPI support doesn't honor the ENABLE_NETSCAPE_PLUGIN_API DEFINE in WebKit2 s/DEFINE/define/ > Source/WebKit2/WebKit2.pro:582 > + DEFINES += PLUGIN_ARCHITECTURE_UNSUPPORTED Indentation should be 4 spaces here, not 8.
Pierre Rossi
Comment 3 2011-08-29 07:57:29 PDT
Created attachment 105491 [details] Patch
WebKit Review Bot
Comment 4 2011-08-29 09:07:41 PDT
Comment on attachment 105491 [details] Patch Clearing flags on attachment: 105491 Committed r93979: <http://trac.webkit.org/changeset/93979>
WebKit Review Bot
Comment 5 2011-08-29 09:07:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.