Bug 67110

Summary: [EFL] Add const modifier to passed objects where it's recommended
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
updated patch none

Grzegorz Czajkowski
Reported 2011-08-29 00:04:08 PDT
Add const modifier to passed Evas_Object if the function doesn't change its (the most cases to the getter functions).
Attachments
proposed patch (27.29 KB, patch)
2011-08-29 00:05 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
updated patch (27.27 KB, patch)
2011-08-30 01:33 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2011-08-29 00:05:16 PDT
Created attachment 105464 [details] proposed patch
Gyuyoung Kim
Comment 2 2011-08-29 03:01:51 PDT
Although this patch is huge, looks good to me. I'm not sure if this patch needs to be split into smaller's patches. CC'ing Kent.
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-08-29 05:33:17 PDT
Looks OK if everything still builds fine (although the patch is quite large). > Source/WebKit/efl/ChangeLog:8 > + Add const modifier to passed Evas_Object if the function doesn't change its (the most doesn't change its what?
Grzegorz Czajkowski
Comment 4 2011-08-30 01:33:30 PDT
Created attachment 105593 [details] updated patch
Grzegorz Czajkowski
Comment 5 2011-08-30 01:35:51 PDT
(In reply to comment #3) > Looks OK if everything still builds fine (although the patch is quite large). > Should I split it into smaller patches? > > Source/WebKit/efl/ChangeLog:8 > > + Add const modifier to passed Evas_Object if the function doesn't change its (the most > > doesn't change its what? fixed
WebKit Review Bot
Comment 6 2011-08-30 02:38:05 PDT
Comment on attachment 105593 [details] updated patch Clearing flags on attachment: 105593 Committed r94063: <http://trac.webkit.org/changeset/94063>
WebKit Review Bot
Comment 7 2011-08-30 02:38:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.