Bug 67099

Summary:

[CG] ImageBufferCG should handle IOSurface allocation failure gracefully

Product:

WebKit

Reporter:

Matthew Delaney <mdelaney7>

Component:

Canvas

Assignee:

Matthew Delaney <mdelaney7>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mdelaney7, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch1	simon.fraser: review+

Description Matthew Delaney 2011-08-28 20:55:35 PDT

In ImageBufferCG ctor, if IOSurface creation fails we just bail out, but instead should just attempt the create a backing store via the (old) non-accel path.

Comment 1 Matthew Delaney 2011-08-28 20:55:49 PDT

<rdar://problem/9948461>

Comment 2 Matthew Delaney 2011-08-28 22:08:13 PDT

Created attachment 105459 [details]
patch1

Comment 3 Simon Fraser (smfr) 2011-08-28 22:33:41 PDT

Comment on attachment 105459 [details]
patch1

View in context: https://bugs.webkit.org/attachment.cgi?id=105459&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests - doesn't change behavior.
> +

Sure it does, just not in a way that's easily testable.

Comment 4 Matthew Delaney 2011-08-29 15:52:42 PDT

Committed r94024: <http://trac.webkit.org/changeset/94024>