Bug 67055

Summary: [Qt] Do not unconditionally use pkg-config in .pro files
Product: WebKit Reporter: Ademar Reis <ademar>
Component: New BugsAssignee: Ademar Reis <ademar>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Ademar Reis 2011-08-26 13:03:56 PDT
[Qt] Do not unconditionally use pkg-config in .pro files
Comment 1 Ademar Reis 2011-08-29 13:27:22 PDT
Created attachment 105516 [details]
Patch
Comment 2 Alexis Menard (darktears) 2011-08-29 15:39:36 PDT
Comment on attachment 105516 [details]
Patch

LGTM.
Comment 3 Andreas Kling 2011-08-29 17:13:49 PDT
Comment on attachment 105516 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2011-08-29 18:18:47 PDT
Comment on attachment 105516 [details]
Patch

Rejecting attachment 105516 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
NS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295

Died at Tools/Scripts/update-webkit line 150.

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 9
Updating OpenSource
RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295

Died at Tools/Scripts/update-webkit line 150.

Full output: http://queues.webkit.org/results/9564305
Comment 5 WebKit Review Bot 2011-08-30 06:56:44 PDT
Comment on attachment 105516 [details]
Patch

Clearing flags on attachment: 105516

Committed r94075: <http://trac.webkit.org/changeset/94075>
Comment 6 WebKit Review Bot 2011-08-30 06:56:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Ademar Reis 2011-08-30 10:52:29 PDT
Revision r94075 cherry-picked into qtwebkit-2.2 with commit fb3b470 <http://gitorious.org/webkit/qtwebkit/commit/fb3b470>