Bug 67055

Summary: [Qt] Do not unconditionally use pkg-config in .pro files
Product: WebKit Reporter: Ademar Reis <ademar>
Component: New BugsAssignee: Ademar Reis <ademar>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ademar Reis
Reported 2011-08-26 13:03:56 PDT
[Qt] Do not unconditionally use pkg-config in .pro files
Attachments
Patch (3.82 KB, patch)
2011-08-29 13:27 PDT, Ademar Reis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ademar Reis
Comment 1 2011-08-29 13:27:22 PDT
Created attachment 105516 [details] Patch
Alexis Menard (darktears)
Comment 2 2011-08-29 15:39:36 PDT
Comment on attachment 105516 [details] Patch LGTM.
Andreas Kling
Comment 3 2011-08-29 17:13:49 PDT
Comment on attachment 105516 [details] Patch r=me
WebKit Review Bot
Comment 4 2011-08-29 18:18:47 PDT
Comment on attachment 105516 [details] Patch Rejecting attachment 105516 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: NS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at Tools/Scripts/update-webkit line 150. Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 9 Updating OpenSource RA layer request failed: OPTIONS of 'http://svn.webkit.org/repository/webkit': could not connect to server (http://svn.webkit.org) at /usr/lib/git-core/git-svn line 2295 Died at Tools/Scripts/update-webkit line 150. Full output: http://queues.webkit.org/results/9564305
WebKit Review Bot
Comment 5 2011-08-30 06:56:44 PDT
Comment on attachment 105516 [details] Patch Clearing flags on attachment: 105516 Committed r94075: <http://trac.webkit.org/changeset/94075>
WebKit Review Bot
Comment 6 2011-08-30 06:56:49 PDT
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 7 2011-08-30 10:52:29 PDT
Revision r94075 cherry-picked into qtwebkit-2.2 with commit fb3b470 <http://gitorious.org/webkit/qtwebkit/commit/fb3b470>
Note You need to log in before you can comment on or make changes to this bug.