Bug 67023

Summary: Add prefix to LayoutTest/http/tests/filesystem/resources/fs-worker-common.js
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: New BugsAssignee: Taiju Tsuiki <tzik>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Taiju Tsuiki
Reported 2011-08-26 00:46:06 PDT
Add prefix to LayoutTest/http/tests/filesystem/resources/fs-worker-common.js
Attachments
Patch (1.26 KB, patch)
2011-08-26 00:46 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2011-08-26 06:01 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (2.04 KB, patch)
2011-08-29 00:12 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (4.33 KB, patch)
2011-12-20 22:14 PST, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Taiju Tsuiki
Comment 1 2011-08-26 00:46:51 PDT
Created attachment 105324 [details] Patch
WebKit Review Bot
Comment 2 2011-08-26 00:50:35 PDT
Attachment 105324 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Taiju Tsuiki
Comment 3 2011-08-26 01:04:18 PDT
WorkerFileSystemTest.ResolveURLHttpTests seems to fail in chromium due to this. see http://crbug.com/77442
Taiju Tsuiki
Comment 4 2011-08-26 06:01:18 PDT
Created attachment 105352 [details] Patch
WebKit Review Bot
Comment 5 2011-08-26 06:03:10 PDT
Attachment 105352 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1 LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Taiju Tsuiki
Comment 6 2011-08-29 00:12:58 PDT
Created attachment 105467 [details] Patch
Darin Adler
Comment 7 2011-08-29 11:01:06 PDT
Comment on attachment 105467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105467&action=review > LayoutTests/ChangeLog:4 > + Add 'webkit' prefix to filesystem-related layout test utility. > + https://bugs.webkit.org/show_bug.cgi?id=67023 Need to say why not just what we are doing.
Eric Seidel (no email)
Comment 8 2011-12-19 12:12:40 PST
Comment on attachment 105467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105467&action=review >> LayoutTests/ChangeLog:4 >> + https://bugs.webkit.org/show_bug.cgi?id=67023 > > Need to say why not just what we are doing. I agree with Darin the ChangeLog should say "why". Otherwise this change is fine.
Taiju Tsuiki
Comment 9 2011-12-20 22:14:37 PST
Created attachment 120144 [details] Patch
Taiju Tsuiki
Comment 10 2011-12-20 22:19:25 PST
Sorry for very late response. How about this one?
Eric Seidel (no email)
Comment 11 2011-12-21 11:49:44 PST
Comment on attachment 120144 [details] Patch Perfect. Thank you.
WebKit Review Bot
Comment 12 2011-12-21 12:44:22 PST
Comment on attachment 120144 [details] Patch Rejecting attachment 120144 [details] from commit-queue. New failing tests: compositing/iframes/scrolling-iframe.html compositing/iframes/iframe-resize.html Full output: http://queues.webkit.org/results/10999062
WebKit Review Bot
Comment 13 2011-12-22 01:41:00 PST
Comment on attachment 120144 [details] Patch Clearing flags on attachment: 120144 Committed r103505: <http://trac.webkit.org/changeset/103505>
WebKit Review Bot
Comment 14 2011-12-22 01:41:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.