Summary: | [chromium] Remove unsafe raw GraphicsContext3D pointer from ProgramBinding | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrienne Walker <enne> | ||||||
Component: | New Bugs | Assignee: | Adrienne Walker <enne> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | enne, jamesr, nduca | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Adrienne Walker
2011-08-25 17:31:29 PDT
Created attachment 105284 [details]
Patch
This came out of a discussion with jamesr and I figured I'd throw together a quick patch. I would land this after 66981. Comment on attachment 105284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105284&action=review I think this'll hit ASSERT()s if we ever actually tried to clean stuff up in LayerRendererChromium, unless I'm misreading how cleanup() works which is very possible. > Source/WebCore/ChangeLog:8 > + Covered by existing tests. I think that's actually a bit optimistic, we don't have any test coverage that this stuff is cleaned up. > Source/WebCore/platform/graphics/chromium/ProgramBinding.cpp:67 > + GLC(context, context->deleteProgram(m_program)); > +} don't you need to clear m_program here to avoid hitting the assert in the dtor? Created attachment 105855 [details]
Patch
(In reply to comment #4) > Created an attachment (id=105855) [details] > Patch You're totally right. I fixed this patch so it actually works and removed the lie that it was being tested automatically. I tested it manually, though. Comment on attachment 105855 [details]
Patch
R=me
Committed r94363: <http://trac.webkit.org/changeset/94363> |