| Summary: | Allow failure of tests-known-to-be-broken-by-Skia on all platforms | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | epoger | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED DUPLICATE | ||||||
| Severity: | Normal | CC: | caryclark, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
epoger
2011-08-25 15:14:54 PDT
Created attachment 105259 [details]
Allow failure of tests-known-to-be-broken-by-Skia on all platforms
Attachment 105259 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/chromium/test_expecta..." exit_code: 1
ERROR: FAILURES FOR <lucid, x86_64, release, cpu>
ERROR: Line:59 Test lacks BUG modifier. animations/animation-api-1.html
ERROR: Line:79 Test lacks BUG modifier. fast/dom/HTMLDataGridElement
ERROR: Line:84 Test lacks BUG modifier. fast/dom/HTMLScriptElement/nested-execution.html
ERROR: Line:88 Test lacks BUG modifier. fast/parser/pre-html5-parser-quirks.html
ERROR: Line:92 Test lacks BUG modifier. fast/harness/sample-fail-mismatch-reftest.html
ERROR: Line:97 Test lacks BUG modifier. transforms/3d
LayoutTests/platform/chromium/test_expectations.txt:59: Test lacks BUG modifier. animations/animation-api-1.html [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:79: Test lacks BUG modifier. fast/dom/HTMLDataGridElement [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:84: Test lacks BUG modifier. fast/dom/HTMLScriptElement/nested-execution.html [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:88: Test lacks BUG modifier. fast/parser/pre-html5-parser-quirks.html [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:92: Test lacks BUG modifier. fast/harness/sample-fail-mismatch-reftest.html [test/expectations] [2]
LayoutTests/platform/chromium/test_expectations.txt:97: Test lacks BUG modifier. transforms/3d [test/expectations] [2]
Total errors found: 6 in 1 files
If any of these errors are false positives, please file a bug against check-webkit-style.
The check-webkit-style errors were not introduced by my patch. Looks like this change loses information. Tests which used to be split out to show that only the debug flavor timed out show that all flavors time out. Also, it doesn't permit showing that MAC-CG (however that's specified) succeeds. Given Cary's comment, I am going to rework this patch to only allow test failures when Skia is enabled. I will also try to figure out what change caused the style failures below and pester the guilty party. The check-webkit-style errors have been fixed in http://trac.webkit.org/changeset/93826 Still reworking this patch to only allow test failures when Skia is enabled. Comment on attachment 105259 [details] Allow failure of tests-known-to-be-broken-by-Skia on all platforms Abandoning in favor of new approach in https://bugs.webkit.org/show_bug.cgi?id=67324 |