Bug 66987

Summary: Allow failure of tests-known-to-be-broken-by-Skia on all platforms
Product: WebKit Reporter: epoger
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: caryclark, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Allow failure of tests-known-to-be-broken-by-Skia on all platforms none

epoger
Reported 2011-08-25 15:14:54 PDT
There are a bunch of tests that are known to fail when using Skia graphics; these tests were allowed to fail in test_expectations.txt, but only for certain platforms. Allowing them to fail for ALL platforms instead, since Skia can be used on many platforms.
Attachments
Allow failure of tests-known-to-be-broken-by-Skia on all platforms (5.58 KB, patch)
2011-08-25 15:23 PDT, epoger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
epoger
Comment 1 2011-08-25 15:23:36 PDT
Created attachment 105259 [details] Allow failure of tests-known-to-be-broken-by-Skia on all platforms
WebKit Review Bot
Comment 2 2011-08-25 15:26:25 PDT
Attachment 105259 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/chromium/test_expecta..." exit_code: 1 ERROR: FAILURES FOR <lucid, x86_64, release, cpu> ERROR: Line:59 Test lacks BUG modifier. animations/animation-api-1.html ERROR: Line:79 Test lacks BUG modifier. fast/dom/HTMLDataGridElement ERROR: Line:84 Test lacks BUG modifier. fast/dom/HTMLScriptElement/nested-execution.html ERROR: Line:88 Test lacks BUG modifier. fast/parser/pre-html5-parser-quirks.html ERROR: Line:92 Test lacks BUG modifier. fast/harness/sample-fail-mismatch-reftest.html ERROR: Line:97 Test lacks BUG modifier. transforms/3d LayoutTests/platform/chromium/test_expectations.txt:59: Test lacks BUG modifier. animations/animation-api-1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:79: Test lacks BUG modifier. fast/dom/HTMLDataGridElement [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:84: Test lacks BUG modifier. fast/dom/HTMLScriptElement/nested-execution.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:88: Test lacks BUG modifier. fast/parser/pre-html5-parser-quirks.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:92: Test lacks BUG modifier. fast/harness/sample-fail-mismatch-reftest.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:97: Test lacks BUG modifier. transforms/3d [test/expectations] [2] Total errors found: 6 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
epoger
Comment 3 2011-08-25 15:33:29 PDT
The check-webkit-style errors were not introduced by my patch.
Cary Clark
Comment 4 2011-08-26 05:03:42 PDT
Looks like this change loses information. Tests which used to be split out to show that only the debug flavor timed out show that all flavors time out. Also, it doesn't permit showing that MAC-CG (however that's specified) succeeds.
epoger
Comment 5 2011-08-26 07:43:56 PDT
Given Cary's comment, I am going to rework this patch to only allow test failures when Skia is enabled. I will also try to figure out what change caused the style failures below and pester the guilty party.
epoger
Comment 6 2011-08-26 14:08:12 PDT
The check-webkit-style errors have been fixed in http://trac.webkit.org/changeset/93826 Still reworking this patch to only allow test failures when Skia is enabled.
epoger
Comment 7 2011-09-01 07:45:57 PDT
Comment on attachment 105259 [details] Allow failure of tests-known-to-be-broken-by-Skia on all platforms Abandoning in favor of new approach in https://bugs.webkit.org/show_bug.cgi?id=67324
epoger
Comment 8 2011-09-01 07:46:43 PDT
*** This bug has been marked as a duplicate of bug 67324 ***
Note You need to log in before you can comment on or make changes to this bug.