Bug 6696

Summary:

REGRESSION: JavaScript window.opener set incorrectly

Product:

WebKit

Reporter:

Julien KRIVACSY <julien>

Component:

DOM

Assignee:

Darin Adler <darin>

Status:

VERIFIED FIXED

Severity:

Normal

CC:

ddkilzer

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.emprint.fr/webkit/test.html

Attachments:

Description	Flags
Target window contents (click on other test file)	none
Test file (click here first)	none
patch that fixes the name collision that created this problem	sullivan: review+

Julien KRIVACSY

Reported 2006-01-21 09:21:08 PST

This bug happen only in WebKit and not in Safari (417.8). When you open a new window using Javascript [window.open(...)], the new window doesn't like to interpret window.opener as the opener window but as itself. We can't send values from one window to another. You can check this at http://www.emprint.fr/webkit/test.html

Attachments
Target window contents (click on other test file) (382 bytes, text/html) 2006-01-23 21:32 PST, David Kilzer (:ddkilzer)	no flags	Details
Test file (click here first) (484 bytes, text/html) 2006-01-23 21:33 PST, David Kilzer (:ddkilzer)	no flags	Details
patch that fixes the name collision that created this problem (3.38 KB, patch) 2006-01-24 12:58 PST, Darin Adler	sullivan: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2006-01-21 09:54:21 PST

Confirmed; setting priority to P1 (regression).

Joost de Valk (AlthA)

Comment 2 2006-01-21 10:05:57 PST

Adding regression keyword and to summary.

David Kilzer (:ddkilzer)

Comment 3 2006-01-23 21:27:16 PST

I'm pretty sure this bug is what's causing Yahoo! Mail's "insert address" feature to stop working. 1. Log in to Yahoo! Mail using Safari+WebKit. 2. Click on "Compose" button. 3. Click on "To:" link. 4. Select an address to add (check a checkbox in the "To" column). 5. Click on "Insert Checked Contacts" button. Expected: The address should be added to the "To:" text box. Actual: Nothing happens.

David Kilzer (:ddkilzer)

Comment 4 2006-01-23 21:32:10 PST

Created attachment 5897 [details] Target window contents (click on other test file)

David Kilzer (:ddkilzer)

Comment 5 2006-01-23 21:33:15 PST

Created attachment 5898 [details] Test file (click here first)

David Kilzer (:ddkilzer)

Comment 6 2006-01-23 21:59:02 PST

Test fails: WebKit-SVN-r11976.dmg Tue Jan 10 4:35:03 GMT 2006 Test works: WebKit-CVS-2006-01-07 09:37:19 GMT.dmg Regression was checked in between revisions r11922 and r11976, inclusive.

David Kilzer (:ddkilzer)

Comment 7 2006-01-24 03:52:12 PST

After further testing, it appears that in ToT WebKit that this is true for the pop-up window, which it shouldn't be: window.opener == window

Darin Adler

Comment 8 2006-01-24 12:05:50 PST

This was a regression from the Frame change, bug 6450. I have a fix.

Darin Adler

Comment 9 2006-01-24 12:58:31 PST

Created attachment 5924 [details] patch that fixes the name collision that created this problem

Julien KRIVACSY

Comment 10 2006-01-25 02:13:39 PST

Thank you :) It's ok in the new release.

David Kilzer (:ddkilzer)

Comment 11 2006-01-25 04:54:15 PST

Marking verified per Comment #10.

Eric Seidel (no email)

Comment 12 2006-01-31 21:20:55 PST

Removing Regression keyword from bugs already fixed.

Note You need to log in before you can comment on or make changes to this bug.