Summary: | [WebAudio] Undeclared dependency to VIDEO | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||||||||||
Component: | Web Audio | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | crogers, dglazkov, donggwan.kim, eric, kbr, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | 67468 | ||||||||||||||||
Bug Blocks: | |||||||||||||||||
Attachments: |
|
Description
Philippe Normand
2011-08-24 14:40:28 PDT
Created attachment 105138 [details]
proposed patch
Comment on attachment 105138 [details] proposed patch Attachment 105138 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9511260 Comment on attachment 105138 [details] proposed patch Attachment 105138 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9511284 Comment on attachment 105138 [details] proposed patch Attachment 105138 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9510309 Created attachment 105160 [details]
proposed patch
(In reply to comment #5) > Created an attachment (id=105160) [details] > proposed patch This one should make the Chromium EWS happy. About the mac ews, not sure, it might need a clobber build. Comment on attachment 105160 [details] proposed patch Attachment 105160 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9510377 Created attachment 105475 [details] proposed patch Update after http://trac.webkit.org/changeset/93903 Comment on attachment 105475 [details] proposed patch Attachment 105475 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9567016 Comment on attachment 105475 [details] proposed patch Attachment 105475 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9563114 Comment on attachment 105475 [details] proposed patch Attachment 105475 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9564151 Created attachment 105489 [details]
proposed patch
Comment on attachment 105489 [details] proposed patch Attachment 105489 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9558318 Comment on attachment 105489 [details] proposed patch Attachment 105489 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9564176 Comment on attachment 105489 [details] proposed patch Attachment 105489 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9565154 Created attachment 105492 [details]
proposed patch
Comment on attachment 105492 [details] proposed patch Attachment 105492 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9565160 Comment on attachment 105492 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=105492&action=review Hi Philippe, can you try my suggestion to avoid custom bindings? Thanks, Chris > Source/WebCore/webaudio/AudioContext.idl:62 > + [Custom] MediaElementAudioSourceNode createMediaElementSource(in HTMLMediaElement mediaElement) Can't we avoid using the Custom bindings and instead have something like this: #if defined(ENABLE_VIDEO) && ENABLE_VIDEO MediaElementAudioSourceNode createMediaElementSource(in HTMLMediaElement mediaElement) raises(DOMException); #endif Created attachment 105591 [details]
updated patch
(In reply to comment #18) > (From update of attachment 105492 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=105492&action=review > > Hi Philippe, can you try my suggestion to avoid custom bindings? > Good idea indeed! Thanks for the feedback. Comment on attachment 105591 [details] updated patch Attachment 105591 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9565412 Would you mind review this Kenneth? Chris did a first pass. Comment on attachment 105591 [details]
updated patch
Looks fine to me.
Committed r94389: <http://trac.webkit.org/changeset/94389> I'll have a look at the mac build Build fix is to use Conditional=WEB_AUDIO&VIDEO in MediaElementAudioSourceNode.idl instead of 2 separate Conditional lines. I'll reland the patch, I verified the fix on my mac :) Committed r94397: <http://trac.webkit.org/changeset/94397> |