Bug 66875 – Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Avi Drissman]

Cr bug: http://code.google.com/p/chromium/issues/detail?id=93830

There's a crashing layout test on mac in the gpu config, tested with chromium r97735 + WebKit r93540.  Avi says it's related to a known issue.

To reproduce this crash build DumpRenderTree (the target is in third_party/WebKit/Source/WebKit/chromium/WebKit.xcodeproj) and run it with the following flags:

--test-shell --pixel-tests=/usr/local/home/jamesr/chrome/src/webkit/Debug/layout-test-results/png_result0.png --enable-accelerated-2d-canvas --enable-accelerated-compositing

then pass the following two lines to stdin (separate lines):

$CHROME_REPOSITORY_ROOT/src/third_party/WebKit/LayoutTests/compositing/animation/busy-indicator.html
$CHROME_REPOSITORY_ROOT/src/third_party/WebKit/LayoutTests/compositing/iframes/iframe-size-to-zero.html

The crashing stack is:

#0  0x9069cf8b in objc_msgSend ()
#1  0x0032a5e0 in ?? ()
#2  0x0e1a1f17 in WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb (this=0x11f6d16c, canvas=0x1c4a8620, state=WebKit::WebThemeEngine::StateActive, size=WebKit::WebThemeEngine::SizeRegular, rect=@0xbfffbb28, scrollbarInfo=@0xbfffbb10) at /usr/local/home/jamesr/chrome/src/third_party/WebKit/Source/WebKit/chromium/../../../Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:195
#3  0x0e1a1ab1 in WebThemeEngineDRTMac::paintScrollbarThumb (this=0x11f6d16c, canvas=0x1c4a8620, state=WebKit::WebThemeEngine::StateActive, size=WebKit::WebThemeEngine::SizeRegular, rect=@0xbfffbb28, scrollbarInfo=@0xbfffbb10) at /usr/local/home/jamesr/chrome/src/third_party/WebKit/Source/WebKit/chromium/../../../Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:106

[Avi Drissman]

Created attachment 105037 [details]
Patch

[James Robinson]

Comment on attachment 105037 [details]
Patch

Hurray!  Thanks for fixing this.

[WebKit Review Bot]

Comment on attachment 105037 [details]
Patch

Clearing flags on attachment: 105037

Committed r93724: <http://trac.webkit.org/changeset/93724>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.