Bug 66866 – [EFL] Add API to call Frame::scalePage.

• Component: New Bugs
• Status: RESOLVED INVALID

[Raphael Kubo da Costa (:rakuco)]

[EFL] Add API to call Frame::scalePage.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 105020 [details]
Patch

[Ryuan Choi]

I'm not sure.

IMO, we have too many zoom related apis.

Please see Bug 62842 .

Now we are testing this to replace cairo scaling, local patch.

[Raphael Kubo da Costa (:rakuco)]

Some parts of both patches do overlap. I have a few questions/concerns about dropping this one altogether in favor of the other patch:

a) I did not understand what you mean with "Now we are testing this to replace cairo scaling, local patch". Do you mean you will upload a new patch to bug 62842?
b) Is the behaviour of that code going to be the same as the one here? _ewk_view_smart_zoom_set does more than this internal function.
c) The parameter types are different in this function and ewk_view_zoom_set.

[Ryuan Choi]

(In reply to comment #3)
> Some parts of both patches do overlap. I have a few questions/concerns about dropping this one altogether in favor of the other patch:
> 
> a) I did not understand what you mean with "Now we are testing this to replace cairo scaling, local patch". Do you mean you will upload a new patch to bug 62842?

Sorry for the confusion. I means that we are refactoring local patches(cairo scaling) to it.

> b) Is the behaviour of that code going to be the same as the one here? _ewk_view_smart_zoom_set does more than this internal function.
> c) The parameter types are different in this function and ewk_view_zoom_set.

OK. after more thinking, Bug 62842 can change to use this.
I'll check zoom related APIs more and make new patch for Bug 62842.

So, this patch is fine to me.

[Kenneth Rohde Christiansen]

Comment on attachment 105020 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105020&action=review

> Source/WebKit/efl/ChangeLog:10
> +        This bit of API is required by DRT's EventSender, as it is used by
> +        tests which call zoom-related code, such as
> +        fast/dom/Element/scale-page-client-rects.html.

For DRT add in something like DumpRenderTreeSupport class, if really needed at all.

[Raphael Kubo da Costa (:rakuco)]

Right, I'm closing this one and will put it in a separate report with DumpRenderTreeSupportEfl.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 105020 [details]
Patch

Removing the cq? flag.