Bug 66864

Summary: JSHTMLImageElement (and associated Node) is abandoned when image load is canceled
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2011-08-24 10:28:31 PDT
JSHTMLImageElement (and associated Node) is abandoned when image load is canceled
Attachments
Patch (1.68 KB, patch)
2011-08-24 10:35 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-08-24 10:34:07 PDT
In the JSC bindings, we use HTMLImageElement::hasPendingActivity() (which in turn calls HTMLImageLoader::haveFiredLoadEvent()) to reason about the liveness of JSHTMLImageElements. In the case that an image load is canceled, the haveFiredLoadEvent never true, so the JSHTMLImageElement is kept alive forever (and since it references the global object, it keeps the entire graph alive as well).
Sam Weinig
Comment 2 2011-08-24 10:35:48 PDT
Created attachment 105015 [details] Patch
Sam Weinig
Comment 3 2011-08-24 10:37:38 PDT
<rdar://problem/9925630>
Sam Weinig
Comment 4 2011-08-24 11:28:16 PDT
Committed r93717: <http://trac.webkit.org/changeset/93717>
Note You need to log in before you can comment on or make changes to this bug.