Bug 66862

Summary: [chromium] Renderer crashes if compositor runs out of texture memory
Product: WebKit Reporter: Iain Merrick <husky>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, husky, jamesr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
gdb backtrace
none
Patch none

Iain Merrick
Reported 2011-08-24 10:18:19 PDT
To reproduce: load http://diden.net/test/tex.html and move the slider to the right. The renderer reliably crashes at around 60. (That might be because of the hard-coded texture limit of 64MB. The usage reported by the page may not be accurate, though, because of tiling.) Possibly related to TextureManager refactoring? https://bugs.webkit.org/show_bug.cgi?id=64772 The old behavior was just to skip drawing some layers, but that wasn't really ideal either.
Attachments
gdb backtrace (6.63 KB, text/plain)
2011-08-24 11:36 PDT, Iain Merrick 		no flags
Details
Patch (1.61 KB, patch)
2011-08-24 14:48 PDT, Iain Merrick 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Iain Merrick
Comment 1 2011-08-24 10:31:47 PDT
It's an assert: ./gpu/command_buffer/client/../client/gles2_implementation_autogen.h(287): GPU_DCHECK(textures[i] != 0 (0)) failed.
James Robinson
Comment 2 2011-08-24 11:18:14 PDT
Stack?
Iain Merrick
Comment 3 2011-08-24 11:36:46 PDT
Created attachment 105029 [details] gdb backtrace Looks like we're just deleting 0? I think that's kosher so maybe the DCHECK isn't needed. No crash in release builds.
James Robinson
Comment 4 2011-08-24 12:44:20 PDT
Yeah, I've been assuming that deleting texture 0 is safe. It's quite easy to avoid calling deleteTexture() on zero if the underlying stack is unhappy with it, though.
Iain Merrick
Comment 5 2011-08-24 14:48:05 PDT
Created attachment 105072 [details] Patch
Iain Merrick
Comment 6 2011-08-24 14:48:57 PDT
Turns out we got stricter back in June - http://code.google.com/p/chromium/issues/detail?id=85268
James Robinson
Comment 7 2011-08-24 14:52:56 PDT
Comment on attachment 105072 [details] Patch Ah, OK. I wasn't aware of that change (or more likely just forgot about it).
WebKit Review Bot
Comment 8 2011-08-24 15:10:10 PDT
Comment on attachment 105072 [details] Patch Clearing flags on attachment: 105072 Committed r93743: <http://trac.webkit.org/changeset/93743>
WebKit Review Bot
Comment 9 2011-08-24 15:10:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.