Bug 66857

Summary: [EFL] Add API to clear the frame name.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED INVALID    
Severity: Normal CC: kenneth, leandro
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2011-08-24 07:04:26 PDT
[EFL] Add API to clear the frame name.
Attachments
Patch (2.71 KB, patch)
2011-08-24 07:08 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-08-24 07:08:16 PDT
Created attachment 104994 [details] Patch
Antonio Gomes
Comment 2 2011-08-24 08:32:22 PDT
Comment on attachment 104994 [details] Patch Have you consider have a DRTSupportEfl, like Qt and Gtk does, so API does not get needlessly inflated?
Raphael Kubo da Costa (:rakuco)
Comment 3 2011-08-24 08:36:57 PDT
It would probably involve making the smart data structs in each file visible to other parts of the code (otherwise this patch for example would not be able to access sd->frame), so we ended up just putting the API in the file that makes the internal data available. That can change in the future, but would require us to sit down a bit and do some rewrites.
Raphael Kubo da Costa (:rakuco)
Comment 4 2011-09-20 09:58:50 PDT
I've adopted the DRTSupportEfl approach and will submit a separate patch later.
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-09-20 09:59:04 PDT
Comment on attachment 104994 [details] Patch Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.