[CSSRegions] RenderRegion is not used if there's another renderer after it

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Alexandru Chiculita]

RenderRegion is only added to the RenderFlowThread if there's no renderer after it in the container box. That's because only RenderObjectChildList::removeChildNode and RenderObjectChildList::appendChildNode were patched to add RenderRegion checks. The RenderObjectChildList::insertChildNode also needs to be updated to take care of insertions.

[Alexandru Chiculita]

Created attachment 104984 [details]
Patch V1

[Alexandru Chiculita]

Created attachment 104985 [details]
Patch V2

[Dave Hyatt]

Comment on attachment 104985 [details]
Patch V2

r=me

[WebKit Review Bot]

Comment on attachment 104985 [details]
Patch V2

Rejecting attachment 104985 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
cted.txt
patching file LayoutTests/fast/regions/content-flowed-into-regions-dynamically-inserted.html
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderObjectChildList.cpp
Hunk #1 FAILED at 244.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderObjectChildList.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Hyatt', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/9493014

[Alexandru Chiculita]

Created attachment 105027 [details]
Patch Rebased

[Dave Hyatt]

Comment on attachment 105027 [details]
Patch Rebased

r=me

[WebKit Review Bot]

Comment on attachment 105027 [details]
Patch Rebased

Clearing flags on attachment: 105027

Committed r93721: <http://trac.webkit.org/changeset/93721>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.