Bug 6683

Summary:

break render_table out into separate files (one per class)

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

WebKit Misc.

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
proposed patch.	bdakin: review+

Eric Seidel (no email)

Reported 2006-01-20 00:02:19 PST

break render_table out into separate files (one per class) I also am moving render_container to RenderContainer and render_block to RenderBlock at the same time.

Attachments
proposed patch. (677.89 KB, patch) 2006-01-20 00:03 PST, Eric Seidel (no email)	bdakin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2006-01-20 00:03:19 PST

Created attachment 5795 [details] proposed patch.

Eric Seidel (no email)

Comment 2 2006-01-20 00:04:27 PST

Comment on attachment 5795 [details] proposed patch. More of the same. This patch breaks render_table out into separate files (one per class) and moves render_block to RenderBlock and render_container to RenderContainer. I used my split_class.pl script like always, then just went through and cleaned up the headers.

Beth Dakin

Comment 3 2006-01-20 10:25:03 PST

Comment on attachment 5795 [details] proposed patch. Part of me likes having all of the table classes in one file, but this is probably better. It does seem much cleaner this way. So r=me!

Darin Adler

Comment 4 2006-01-21 11:21:22 PST

Eric landed this Thursday.

Note You need to log in before you can comment on or make changes to this bug.