Bug 66828

Summary: REGRESSION(r93645): Broke webkit_unit_tests on chromium mac (Requested by jamesr on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: asvitkine, dglazkov, thakis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66707    
Attachments:
Description Flags
ROLLOUT of r93645
none
Remove FindSafari
none
Remove FindSafari none

WebKit Review Bot
Reported 2011-08-23 17:34:46 PDT
http://trac.webkit.org/changeset/93645 broke the build: Broke webkit_unit_tests on chromium mac (Requested by jamesr on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r93645 (3.50 KB, patch)
2011-08-23 17:35 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
Remove FindSafari (51.63 KB, patch)
2011-09-22 09:33 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Remove FindSafari (51.63 KB, patch)
2011-09-22 09:35 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-08-23 17:35:14 PDT
Created attachment 104945 [details] ROLLOUT of r93645 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment.
Nico Weber
Comment 2 2011-08-23 17:57:28 PDT
This depended on a resource Cl in chromium land. I assume upstream deps just weren't rolled to that yet.
WebKit Review Bot
Comment 3 2011-08-23 18:00:20 PDT
Comment on attachment 104945 [details] ROLLOUT of r93645 Clearing flags on attachment: 104945 Committed r93676: <http://trac.webkit.org/changeset/93676>
WebKit Review Bot
Comment 4 2011-08-23 18:00:24 PDT
All reviewed patches have been landed. Closing bug.
Adam Roben (:aroben)
Comment 5 2011-09-22 09:33:54 PDT
Created attachment 108347 [details] Remove FindSafari
Adam Roben (:aroben)
Comment 6 2011-09-22 09:35:34 PDT
Created attachment 108348 [details] Remove FindSafari
Adam Roben (:aroben)
Comment 7 2011-09-22 09:36:55 PDT
Comment on attachment 108347 [details] Remove FindSafari Sorry, this was meant for another bug.
Adam Roben (:aroben)
Comment 8 2011-09-22 09:37:18 PDT
Comment on attachment 108348 [details] Remove FindSafari Sorry, this was meant for another bug.
Note You need to log in before you can comment on or make changes to this bug.