Bug 66813

Summary: fast/multicol/span/span-as-nested-inline-block-child.html is misleading
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: Layout and RenderingAssignee: Peter Kasting <pkasting>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, bfulgham, dglazkov, hyatt, simon.fraser, webkit.review.bot, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update test text rniwa: review-, webkit.review.bot: commit-queue-

Peter Kasting
Reported 2011-08-23 15:07:10 PDT
Per IRC conversation with dhyatt: The text on fast/multicol/span/span-as-nested-inline-block-child.html should just say that all the text should be in the columns, and none should span across both columns. It's not a requirement that the third paragraph start in the left column.
Attachments
Update test text (1.69 KB, patch)
2011-08-29 13:56 PDT, Peter Kasting
rniwa: review-
webkit.review.bot: commit-queue-
Peter Kasting
Comment 1 2011-08-29 13:56:58 PDT
Created attachment 105519 [details] Update test text Hyatt, how's this look? I have been told that the easiest way for me to get new baselines for this test is to check in, wait for the builders to fail, and then use webkit-patch to rebaseline :(.
WebKit Review Bot
Comment 2 2011-08-29 14:31:27 PDT
Comment on attachment 105519 [details] Update test text Attachment 105519 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9567190 New failing tests: fast/multicol/span/span-as-nested-inline-block-child.html
Ryosuke Niwa
Comment 3 2011-09-14 20:49:42 PDT
Comment on attachment 105519 [details] Update test text View in context: https://bugs.webkit.org/attachment.cgi?id=105519&action=review > LayoutTests/ChangeLog:8 > + * fast/multicol/span/span-as-nested-inline-block-child.html: Please rebaseline the test on some platform.
Peter Kasting
Comment 4 2011-09-15 09:54:19 PDT
(In reply to comment #3) > Please rebaseline the test on some platform. That won't help all the other platforms. I'd still need to check in and then collect baselines for (n - 1) platforms. I don't see how rebaselining one makes any difference. Besides this I'm not in a position to be able to rebaseline on any platforms :( Help?
Ahmad Saleem
Comment 5 2023-08-23 12:25:39 PDT
We have this test twice: fast/multicol/span/span-as-nested-inline-block-child.html and fast/multicol/newmulticol/compare-with-old-impl/span-as-nested-inline-block-child.html We can delete one copy and if needed, I can rebaseline this based on this patch. Adding 'Alan' because it seems to be 'Layout' related test.
Note You need to log in before you can comment on or make changes to this bug.