Summary: | Fix mergeChangeLogs test on native windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
Component: | New Bugs | Assignee: | Patrick R. Gansterer <paroga> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Patrick R. Gansterer
2011-08-23 12:03:51 PDT
Created attachment 104884 [details]
Patch
Comment on attachment 104884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104884&action=review > Tools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:53 > - DIR => ($ENV{'TMPDIR'} || "/tmp"), > + DIR => ($ENV{'TMPDIR'} || $ENV{'TEMP'} || "/tmp"), It would be even better to use File::Spec->tmpdir(). Comment on attachment 104884 [details] Patch Clearing flags on attachment: 104884 Committed r93649: <http://trac.webkit.org/changeset/93649> All reviewed patches have been landed. Closing bug. |