Bug 66797

Summary: Fix mergeChangeLogs test on native windows
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: New BugsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2011-08-23 12:03:51 PDT
Fix mergeChangeLogs test on native windows
Attachments
Patch (1.48 KB, patch)
2011-08-23 12:09 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-08-23 12:09:24 PDT
Created attachment 104884 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-08-23 12:12:32 PDT
Comment on attachment 104884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104884&action=review > Tools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:53 > - DIR => ($ENV{'TMPDIR'} || "/tmp"), > + DIR => ($ENV{'TMPDIR'} || $ENV{'TEMP'} || "/tmp"), It would be even better to use File::Spec->tmpdir().
WebKit Review Bot
Comment 3 2011-08-23 16:07:34 PDT
Comment on attachment 104884 [details] Patch Clearing flags on attachment: 104884 Committed r93649: <http://trac.webkit.org/changeset/93649>
WebKit Review Bot
Comment 4 2011-08-23 16:07:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.