Summary: | [Qt] Build fails on Lion | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tor Arne Vestbø <vestbo> | ||||
Component: | New Bugs | Assignee: | Tor Arne Vestbø <vestbo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ademar, menard, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tor Arne Vestbø
2011-08-23 06:06:04 PDT
Created attachment 104833 [details]
Patch
Attachment 104833 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:20: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Source/WebCore/ChangeLog:20: Line contains tab character. [whitespace/tab] [5] > Total errors found: 1 in 5 files Gah, I'll fix before landing. Comment on attachment 104833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104833&action=review > w/Source/WebKit/qt/ChangeLog:17 > + We were mistakenly picking up mac/WebCoreSystemInterface.h instead of > + the Qt one, and building on Lion revealed this when a typedef for > + IOSurfaceRef was wrapped in PLATFORM(MAC). > + > + For now we fix this by including WebCoreSystemInterface using > + brackets, so that we'll pick up the right file based on the > + include paths. This also means exposing a few missing enums > + in our own version of the file, so those were added. > + Not relevant for this particular Changelog Comment on attachment 104833 [details]
Patch
rs=me
Good job Revision r93600 cherry-picked into qtwebkit-2.2 with commit f011bd5 <http://gitorious.org/webkit/qtwebkit/commit/f011bd5> |