Bug 66763

Summary: Remove last occurrences of PLATFORM(ANDROID)
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: mnaganov, peter, satish, steveblock, tonyg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66688    
Attachments:
Description Flags
Patch tonyg: review+

Description Steve Block 2011-08-23 04:31:47 PDT
See also Bug 66741
Comment 1 Steve Block 2011-08-23 04:36:47 PDT
Created attachment 104819 [details]
Patch
Comment 2 Tony Gentilcore 2011-08-23 05:22:06 PDT
Comment on attachment 104819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104819&action=review

> Source/WebCore/bindings/v8/V8GCController.cpp:-476
> -    static const int highUsageDeltaMB = -1;

Any background on this? Should it still be present as OS(ANDROID)?
Comment 3 Steve Block 2011-08-23 05:51:16 PDT
Comment on attachment 104819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104819&action=review

>> Source/WebCore/bindings/v8/V8GCController.cpp:-476
>> -    static const int highUsageDeltaMB = -1;
> 
> Any background on this? Should it still be present as OS(ANDROID)?

I guess we're not sure yet, as I don't know if or how we'll provide this functionality via the Chromium port.

In any case, switching it to OS(ANDROID) now will mean that it won't compile, so I thought it best to remove it to allow us to get the Chromium port building for Android ASAP. Peter, do you have any thoughts?
Comment 4 Tony Gentilcore 2011-08-23 05:57:00 PDT
(In reply to comment #3)
> (From update of attachment 104819 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104819&action=review
> 
> >> Source/WebCore/bindings/v8/V8GCController.cpp:-476
> >> -    static const int highUsageDeltaMB = -1;
> > 
> > Any background on this? Should it still be present as OS(ANDROID)?
> 
> I guess we're not sure yet, as I don't know if or how we'll provide this functionality via the Chromium port.
> 
> In any case, switching it to OS(ANDROID) now will mean that it won't compile, so I thought it best to remove it to allow us to get the Chromium port building for Android ASAP. Peter, do you have any thoughts?

Sounds good.
Comment 5 Peter Beverloo 2011-08-23 06:01:19 PDT
I agree on removing them for now.
Re-adding these three variables is trivial and could easily be done as part of supporting the methods in Chromium's PlatformBridge after we decide on how to implement the functionality.
Comment 6 Steve Block 2011-08-23 06:07:40 PDT
Committed r93597: <http://trac.webkit.org/changeset/93597>