Bug 66761

Summary: Investigate current uses of OS(ANDROID)
Product: WebKit Reporter: Peter Beverloo <peter>
Component: WebCore Misc.Assignee: Andrei Popescu <andreip>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, kbalazs, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66688    
Attachments:
Description Flags
Patch none

Peter Beverloo
Reported 2011-08-23 04:22:17 PDT
Various parts of WebCore currently have code guarded by OS(ANDROID), verify that these are still relevant in the new situation and remove or adjust them where they're not.
Attachments
Patch (7.20 KB, patch)
2011-08-30 10:58 PDT, Andrei Popescu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrei Popescu
Comment 1 2011-08-23 09:51:47 PDT
I think I will remove all of them. We should add back those that we need and we should add them back in new patches that show the full context of why they are needed.
Andrei Popescu
Comment 2 2011-08-30 10:58:10 PDT
Created attachment 105653 [details] Patch
Steve Block
Comment 3 2011-08-30 13:00:00 PDT
Comment on attachment 105653 [details] Patch LGTM
WebKit Review Bot
Comment 4 2011-08-31 08:09:16 PDT
Comment on attachment 105653 [details] Patch Clearing flags on attachment: 105653 Committed r94191: <http://trac.webkit.org/changeset/94191>
WebKit Review Bot
Comment 5 2011-08-31 08:09:21 PDT
All reviewed patches have been landed. Closing bug.
Balazs Kelemen
Comment 6 2011-08-31 08:42:52 PDT
Somehow it breaks the QtLinux ARMv7 build :( In file included from ../../../Source/JavaScriptCore/config.h:30, from ../../../Source/JavaScriptCore/yarr/YarrInterpreter.cpp:27: ../../../Source/JavaScriptCore/wtf/Platform.h:180: error: missing binary operator before token "#" In file included from ../../../Source/JavaScriptCore/config.h:30, from ../../../Source/JavaScriptCore/yarr/YarrPattern.cpp:27: ../../../Source/JavaScriptCore/wtf/Platform.h:180: error: missing binary operator before token "#" In file included from ../../../Source/JavaScriptCore/config.h:30, from ../../../Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp:26: ../../../Source/JavaScriptCore/wtf/Platform.h:180: error: missing binary operator before token "#" In file included from ../../../Source/JavaScriptCore/config.h:30, from ../../../Source/JavaScriptCore/wtf/Assertions.cpp:33: ../../../Source/JavaScriptCore/wtf/Platform.h:180: error: missing binary operator before token "#"
Andrei Popescu
Comment 7 2011-08-31 08:48:17 PDT
Sorry about that, I relied on the trybots :) Fixed in http://trac.webkit.org/changeset/94192
Note You need to log in before you can comment on or make changes to this bug.