Summary: | Add handling of mix-width and max-width for flexitems | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hyatt, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 62048 | ||||||||
Attachments: |
|
Description
Tony Chang
2011-08-22 15:08:10 PDT
Created attachment 104748 [details]
Patch
Comment on attachment 104748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104748&action=review r=me > Source/WebCore/rendering/RenderFlexibleBox.cpp:187 > + LayoutUnit flexboxAvailableLogicalWidth = availableLogicalWidth(); Add a FIXME: Deal with writing-modes above this availableLogicalWidth() line, since that's the wrong axis to be looking at if writing-mode is vertical-lr and the box orientation is explicitly horizontal. > Source/WebCore/rendering/RenderFlexibleBox.h:58 > + bool runFreeSpaceAllocationAlgorithm(LayoutUnit& availableFreeSpace, float& totalPositiveFlexibility, float& totalNegativeFlexibility, InflexibleFlexItemSize&); Seems like kind of a generic name for only dealing with horizontal. I don't know if you plan to put vertical in here too though. If so, then don't worry about it. Created attachment 104888 [details]
Patch for landing
(In reply to comment #2) > (From update of attachment 104748 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104748&action=review > > r=me > > > Source/WebCore/rendering/RenderFlexibleBox.cpp:187 > > + LayoutUnit flexboxAvailableLogicalWidth = availableLogicalWidth(); > > Add a FIXME: Deal with writing-modes above this availableLogicalWidth() line, since that's the wrong axis to be looking at if writing-mode is vertical-lr and the box orientation is explicitly horizontal. I added a few FIXMEs about this. I asked Tab about it over email and he said he's not sure what should happen yet and needs to hash out the details Fantasai. (In reply to comment #4) > I added a few FIXMEs about this. I asked Tab about it over email and he said he's not sure what should happen yet and needs to hash out the details [with] Fantasai. Comment on attachment 104888 [details] Patch for landing Clearing flags on attachment: 104888 Committed r93651: <http://trac.webkit.org/changeset/93651> All reviewed patches have been landed. Closing bug. |