Bug 66722

Summary:

Move code from PageClientImpl::doneWithKeyEvent to WKView

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

UI Events

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Anders Carlsson 2011-08-22 15:01:40 PDT

Move code from PageClientImpl::doneWithKeyEvent to WKView

Comment 1 Anders Carlsson 2011-08-22 15:02:09 PDT

Created attachment 104744 [details]
Patch

Comment 2 Darin Adler 2011-08-22 15:05:21 PDT

Comment on attachment 104744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104744&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2060
> +- (void)_doneWithKeyEvent:(const WebKit::NativeWebKeyboardEvent&)event wasEventHandled:(BOOL)wasEventHandled

Objective-C methods that take C++ type arguments end up with super-long selectors. Probably no clean way of avoiding that in this case.

I think the second half of the selection should be eventWasHandled instead of wasEventHandled.

Comment 3 Anders Carlsson 2011-08-22 15:08:38 PDT

Committed r93550: <http://trac.webkit.org/changeset/93550>