Bug 66708 – Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily

• Component: New Bugs
• Status: RESOLVED FIXED

[Nat Duca]

Make GraphicsContext3D::isResourceSafe a function and, on Chromium, determine its value lazily

[Nat Duca]

Created attachment 104730 [details]
Patch

[WebKit Review Bot]

Attachment 104730 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Last 3072 characters of output:
rements: ['./']
  
    name: third_party/ffmpeg
    url: From('chromium_deps', 'src/third_party/ffmpeg')
    parsed_url: http://src.chromium.org/svn/trunk/deps/third_party/ffmpeg/source@97428
    should_process: True
    processed: True
    requirements: ['./', 'chromium_deps', 'third_party']
  
    name: tools/generate_stubs
    url: http://src.chromium.org/svn/trunk/src/tools/generate_stubs@97698
    parsed_url: http://src.chromium.org/svn/trunk/src/tools/generate_stubs@97698
    should_process: True
    processed: True
    requirements: ['./']
  
    name: third_party/libjpeg_turbo
    url: From('chromium_deps', 'src/third_party/libjpeg_turbo')
    parsed_url: http://src.chromium.org/svn/trunk/deps/third_party/libjpeg_turbo@95800
    should_process: True
    processed: True
    requirements: ['./', 'chromium_deps', 'third_party']
  
    name: third_party/v8-i18n
    url: From('chromium_deps', 'src/third_party/v8-i18n')
    parsed_url: http://v8-i18n.googlecode.com/svn/trunk@4
    should_process: True
    processed: True
    requirements: ['./', 'chromium_deps', 'third_party']
  
    name: tools/grit
    url: http://src.chromium.org/svn/trunk/src/tools/grit@97698
    parsed_url: http://src.chromium.org/svn/trunk/src/tools/grit@97698
    should_process: True
    processed: True
    requirements: ['./']
  
    name: base
    url: http://src.chromium.org/svn/trunk/src/base@97698
    parsed_url: http://src.chromium.org/svn/trunk/src/base@97698
    should_process: True
    processed: True
    requirements: ['./']
  
    name: third_party/leveldb
    url: From('chromium_deps', 'src/third_party/leveldb')
    should_process: True
    requirements: ['./', 'chromium_deps', 'third_party']
  
    name: sql
    url: http://src.chromium.org/svn/trunk/src/sql@97698
    should_process: True
    requirements: ['./']
  
    name: v8
    url: From('chromium_deps', 'src/v8')
    should_process: True
    requirements: ['./', 'chromium_deps']
  
    name: testing/gtest
    url: From('chromium_deps', 'src/testing/gtest')
    should_process: True
    requirements: ['./', 'chromium_deps', 'testing']
  
    name: third_party/libwebp
    url: http://src.chromium.org/svn/trunk/src/third_party/libwebp@97698
    should_process: True
    requirements: ['./', 'third_party']
  
    name: googleurl
    url: From('chromium_deps', 'src/googleurl')
    should_process: True
    requirements: ['./', 'chromium_deps']
  
    name: third_party/skia/include
    url: From('chromium_deps', 'src/third_party/skia/include')
    should_process: True
    requirements: ['./', 'chromium_deps', 'third_party']
  
    name: third_party/ots
    url: From('chromium_deps', 'src/third_party/ots')
    should_process: True
    requirements: ['./', 'chromium_deps', 'third_party']
  
    name: third_party/snappy/src
    url: From('chromium_deps', 'src/third_party/snappy/src')
    should_process: True
    requirements: ['./', 'chromium_deps', 'third_party']

Died at Tools/Scripts/update-webkit-chromium line 69.
No such file or directory at Tools/Scripts/update-webkit line 100.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nat Duca]

Right now, the Chromium port queries extension strings during the creation of the context on the main thread. This implicitly makes that context current on the main thread.

By making querying of this sort of state lazy, it avoids accidentally binding to the creating thread.

[Iain Merrick]

Minor style nit: maybe make Unknown the enum's default value?

[Kenneth Russell]

Comment on attachment 104730 [details]
Patch

Looks fine to me. Does this pass check-webkit-style on your machine?

[Nat Duca]

(In reply to comment #5)
> (From update of attachment 104730 [details])
> Looks fine to me. Does this pass check-webkit-style on your machine?

Yes, it passes check-webkit-style. Not sure what went wrong there...

[Nat Duca]

Created attachment 104755 [details]
R U happy now, stylebot?

[Kenneth Russell]

Comment on attachment 104755 [details]
R U happy now, stylebot?

Looks good to me.

[WebKit Review Bot]

Comment on attachment 104755 [details]
R U happy now, stylebot?

Clearing flags on attachment: 104755

Committed r93564: <http://trac.webkit.org/changeset/93564>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.