Bug 6670

Summary:

split html_miscimpl.* and move html_elementimpl.*

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

WebKit Misc.

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
proposed patch.	darin: review+

Eric Seidel (no email)

Reported 2006-01-19 03:46:18 PST

split html_miscimpl.* and move html_elementimpl.* html_miscimpl.* becomes: HTMLFormCollectionImpl.* HTMLCollectionImpl.* HTMLBaseFontElementImpl.* HTMLNameCollectionImpl.* html_elementimpl.* moves to HTMLElementImpl.*

Attachments
proposed patch. (240.47 KB, patch) 2006-01-19 03:47 PST, Eric Seidel (no email)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2006-01-19 03:47:48 PST

Created attachment 5781 [details] proposed patch.

Eric Seidel (no email)

Comment 2 2006-01-19 03:48:43 PST

Comment on attachment 5781 [details] proposed patch. I just used my split script like always... then went back through and fixe the headers. I also cleaned up a couple uses of namespace DOM and namespace khtml while I was in there and removed a couple kdDebug calls. That's it.

Darin Adler

Comment 3 2006-01-19 10:41:56 PST

Comment on attachment 5781 [details] proposed patch. +template <class T> class QPtrVector; I prefer "typename T" to "class T" in such lines and we've been using that syntax as much as possible. Looks great, r=me.

Note You need to log in before you can comment on or make changes to this bug.