Bug 66657 – [NRWT] Fix "Only unexpected results" option of results.html

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

"Only unexpected results" option of results.html only works in WebKit 
based browsers. It doesn't work in the latest FireFox, IE, Opera.

Other browsers simple ignores this checkbox and always shows everything.

[Kristóf Kosztyó]

Created attachment 104666 [details]
proposed fix

[Csaba Osztrogonác]

Comment on attachment 104666 [details]
proposed fix

great, r=me

Let's try CQ. ( Maybe it likes my name now. :) )

[WebKit Review Bot]

Comment on attachment 104666 [details]
proposed fix

Rejecting attachment 104666 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9468658

[Csaba Osztrogonác]

Comment on attachment 104666 [details]
proposed fix

Clearing flags on attachment: 104666

Committed r93508: <http://trac.webkit.org/changeset/93508>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.