Bug 66657

Summary: [NRWT] Fix "Only unexpected results" option of results.html
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Kristóf Kosztyó <kkristof>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed fix none

Description Csaba Osztrogonác 2011-08-22 03:23:14 PDT
"Only unexpected results" option of results.html only works in WebKit 
based browsers. It doesn't work in the latest FireFox, IE, Opera.

Other browsers simple ignores this checkbox and always shows everything.
Comment 1 Kristóf Kosztyó 2011-08-22 06:03:04 PDT
Created attachment 104666 [details]
proposed fix
Comment 2 Csaba Osztrogonác 2011-08-22 06:34:50 PDT
Comment on attachment 104666 [details]
proposed fix

great, r=me

Let's try CQ. ( Maybe it likes my name now. :) )
Comment 3 WebKit Review Bot 2011-08-22 06:36:24 PDT
Comment on attachment 104666 [details]
proposed fix

Rejecting attachment 104666 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/9468658
Comment 4 Csaba Osztrogonác 2011-08-22 06:43:41 PDT
Comment on attachment 104666 [details]
proposed fix

Clearing flags on attachment: 104666

Committed r93508: <http://trac.webkit.org/changeset/93508>
Comment 5 Csaba Osztrogonác 2011-08-22 06:43:48 PDT
All reviewed patches have been landed.  Closing bug.